[FL-1824] Dolphin refactoring (#701)

* refactoring p1
* refactoring p2
* cleanups
* locked screen refresh rate fix
* better locked view logic
* seperate dolphin service and desktop app
* Desktop: Favorite app acess (Left key), Settings app
* Desktop settings version, submenu header
* remove unused icon anomation + naming fix

Co-authored-by: あく <alleteam@gmail.com>

applications/desktop/desktop_settings/desktop_settings.c

@@ -0,0 +1,49 @@
+#include <furi.h>
+#include <file-worker.h>
+#include "desktop_settings.h"
+
+#define DESKTOP_SETTINGS_TAG "Desktop settings"
+#define DESKTOP_SETTINGS_PATH "/int/desktop.settings"
+
+bool desktop_settings_load(DesktopSettings* desktop_settings) {
+    furi_assert(desktop_settings);
+    bool file_loaded = false;
+    DesktopSettings settings = {};
+
+    FURI_LOG_I(DESKTOP_SETTINGS_TAG, "Loading settings from \"%s\"", DESKTOP_SETTINGS_PATH);
+    FileWorker* file_worker = file_worker_alloc(true);
+    if(file_worker_open(file_worker, DESKTOP_SETTINGS_PATH, FSAM_READ, FSOM_OPEN_EXISTING)) {
+        if(file_worker_read(file_worker, &settings, sizeof(settings))) {
+            file_loaded = true;
+        }
+    }
+    file_worker_free(file_worker);
+
+    if(file_loaded) {
+        if(settings.version != DESKTOP_SETTINGS_VER) {
+            FURI_LOG_E(DESKTOP_SETTINGS_TAG, "Settings version mismatch");
+        } else {
+            osKernelLock();
+            *desktop_settings = settings;
+            osKernelUnlock();
+        }
+    } else {
+        FURI_LOG_E(DESKTOP_SETTINGS_TAG, "Settings load failed");
+    }
+    return file_loaded;
+}
+
+bool desktop_settings_save(DesktopSettings* desktop_settings) {
+    furi_assert(desktop_settings);
+    bool result = false;
+
+    FileWorker* file_worker = file_worker_alloc(true);
+    if(file_worker_open(file_worker, DESKTOP_SETTINGS_PATH, FSAM_WRITE, FSOM_OPEN_ALWAYS)) {
+        if(file_worker_write(file_worker, desktop_settings, sizeof(DesktopSettings))) {
+            FURI_LOG_I(DESKTOP_SETTINGS_TAG, "Settings saved to \"%s\"", DESKTOP_SETTINGS_PATH);
+            result = true;
+        }
+    }
+    file_worker_free(file_worker);
+    return result;
+}

applications/desktop/desktop_settings/desktop_settings.h

@@ -0,0 +1,15 @@
+#pragma once
+
+#include <stdint.h>
+#include <stdbool.h>
+
+#define DESKTOP_SETTINGS_VER (0)
+
+typedef struct {
+    uint8_t version;
+    uint16_t favorite;
+} DesktopSettings;
+
+bool desktop_settings_load(DesktopSettings* desktop_settings);
+
+bool desktop_settings_save(DesktopSettings* desktop_settings);

applications/desktop/desktop_settings/desktop_settings_app.c

@@ -0,0 +1,65 @@
+#include "desktop_settings_app.h"
+
+static bool desktop_settings_custom_event_callback(void* context, uint32_t event) {
+    furi_assert(context);
+    DesktopSettingsApp* app = context;
+    return scene_manager_handle_custom_event(app->scene_manager, event);
+}
+
+static bool desktop_settings_back_event_callback(void* context) {
+    furi_assert(context);
+    DesktopSettingsApp* app = context;
+    return scene_manager_handle_back_event(app->scene_manager);
+}
+
+DesktopSettingsApp* desktop_settings_app_alloc() {
+    DesktopSettingsApp* app = furi_alloc(sizeof(DesktopSettingsApp));
+
+    app->settings.version = DESKTOP_SETTINGS_VER;
+    desktop_settings_load(&app->settings);
+
+    app->gui = furi_record_open("gui");
+    app->view_dispatcher = view_dispatcher_alloc();
+    app->scene_manager = scene_manager_alloc(&desktop_settings_scene_handlers, app);
+    view_dispatcher_enable_queue(app->view_dispatcher);
+    view_dispatcher_set_event_callback_context(app->view_dispatcher, app);
+
+    view_dispatcher_set_custom_event_callback(
+        app->view_dispatcher, desktop_settings_custom_event_callback);
+    view_dispatcher_set_navigation_event_callback(
+        app->view_dispatcher, desktop_settings_back_event_callback);
+
+    view_dispatcher_attach_to_gui(app->view_dispatcher, app->gui, ViewDispatcherTypeFullscreen);
+
+    app->submenu = submenu_alloc();
+    view_dispatcher_add_view(
+        app->view_dispatcher, DesktopSettingsAppViewMain, submenu_get_view(app->submenu));
+
+    view_dispatcher_add_view(
+        app->view_dispatcher, DesktopSettingsAppViewFavorite, submenu_get_view(app->submenu));
+
+    scene_manager_next_scene(app->scene_manager, DesktopSettingsAppSceneStart);
+    return app;
+}
+
+void desktop_settings_app_free(DesktopSettingsApp* app) {
+    furi_assert(app);
+    // Variable item list
+    view_dispatcher_remove_view(app->view_dispatcher, DesktopSettingsAppViewMain);
+    view_dispatcher_remove_view(app->view_dispatcher, DesktopSettingsAppViewFavorite);
+    submenu_free(app->submenu);
+    // View dispatcher
+    view_dispatcher_free(app->view_dispatcher);
+    scene_manager_free(app->scene_manager);
+    // Records
+    furi_record_close("gui");
+    free(app);
+}
+
+extern int32_t desktop_settings_app(void* p) {
+    DesktopSettingsApp* app = desktop_settings_app_alloc();
+    view_dispatcher_run(app->view_dispatcher);
+    desktop_settings_save(&app->settings);
+    desktop_settings_app_free(app);
+    return 0;
+}

applications/desktop/desktop_settings/desktop_settings_app.h

@@ -0,0 +1,25 @@
+#pragma once
+
+#include <furi.h>
+#include <gui/gui.h>
+#include <gui/view.h>
+#include <gui/view_dispatcher.h>
+#include <gui/scene_manager.h>
+#include <gui/modules/submenu.h>
+
+#include "desktop_settings.h"
+#include "scenes/desktop_settings_scene.h"
+
+typedef enum {
+    DesktopSettingsAppViewMain,
+    DesktopSettingsAppViewFavorite,
+} DesktopSettingsAppView;
+
+typedef struct {
+    DesktopSettings settings;
+    Gui* gui;
+    SceneManager* scene_manager;
+    ViewDispatcher* view_dispatcher;
+    Submenu* submenu;
+
+} DesktopSettingsApp;

applications/desktop/desktop_settings/scenes/desktop_settings_scene.c

@@ -0,0 +1,30 @@
+#include "desktop_settings_scene.h"
+
+// Generate scene on_enter handlers array
+#define ADD_SCENE(prefix, name, id) prefix##_scene_##name##_on_enter,
+void (*const desktop_settings_on_enter_handlers[])(void*) = {
+#include "desktop_settings_scene_config.h"
+};
+#undef ADD_SCENE
+
+// Generate scene on_event handlers array
+#define ADD_SCENE(prefix, name, id) prefix##_scene_##name##_on_event,
+bool (*const desktop_settings_on_event_handlers[])(void* context, SceneManagerEvent event) = {
+#include "desktop_settings_scene_config.h"
+};
+#undef ADD_SCENE
+
+// Generate scene on_exit handlers array
+#define ADD_SCENE(prefix, name, id) prefix##_scene_##name##_on_exit,
+void (*const desktop_settings_on_exit_handlers[])(void* context) = {
+#include "desktop_settings_scene_config.h"
+};
+#undef ADD_SCENE
+
+// Initialize scene handlers configuration structure
+const SceneManagerHandlers desktop_settings_scene_handlers = {
+    .on_enter_handlers = desktop_settings_on_enter_handlers,
+    .on_event_handlers = desktop_settings_on_event_handlers,
+    .on_exit_handlers = desktop_settings_on_exit_handlers,
+    .scene_num = DesktopSettingsAppSceneNum,
+};

applications/desktop/desktop_settings/scenes/desktop_settings_scene.h

@@ -0,0 +1,29 @@
+#pragma once
+
+#include <gui/scene_manager.h>
+
+// Generate scene id and total number
+#define ADD_SCENE(prefix, name, id) DesktopSettingsAppScene##id,
+typedef enum {
+#include "desktop_settings_scene_config.h"
+    DesktopSettingsAppSceneNum,
+} DesktopSettingsAppScene;
+#undef ADD_SCENE
+
+extern const SceneManagerHandlers desktop_settings_scene_handlers;
+
+// Generate scene on_enter handlers declaration
+#define ADD_SCENE(prefix, name, id) void prefix##_scene_##name##_on_enter(void*);
+#include "desktop_settings_scene_config.h"
+#undef ADD_SCENE
+
+// Generate scene on_event handlers declaration
+#define ADD_SCENE(prefix, name, id) \
+    bool prefix##_scene_##name##_on_event(void* context, SceneManagerEvent event);
+#include "desktop_settings_scene_config.h"
+#undef ADD_SCENE
+
+// Generate scene on_exit handlers declaration
+#define ADD_SCENE(prefix, name, id) void prefix##_scene_##name##_on_exit(void* context);
+#include "desktop_settings_scene_config.h"
+#undef ADD_SCENE

applications/desktop/desktop_settings/scenes/desktop_settings_scene_config.h

@@ -0,0 +1,2 @@
+ADD_SCENE(desktop_settings, start, Start)
+ADD_SCENE(desktop_settings, favorite, Favorite)

applications/desktop/desktop_settings/scenes/desktop_settings_scene_favorite.c

@@ -0,0 +1,47 @@
+#include "../desktop_settings_app.h"
+#include "applications.h"
+
+static void desktop_settings_scene_favorite_submenu_callback(void* context, uint32_t index) {
+    DesktopSettingsApp* app = context;
+    view_dispatcher_send_custom_event(app->view_dispatcher, index);
+}
+
+void desktop_settings_scene_favorite_on_enter(void* context) {
+    DesktopSettingsApp* app = context;
+    Submenu* submenu = app->submenu;
+    submenu_clean(submenu);
+
+    for(size_t i = 0; i < FLIPPER_APPS_COUNT; i++) {
+        submenu_add_item(
+            submenu,
+            FLIPPER_APPS[i].name,
+            i,
+            desktop_settings_scene_favorite_submenu_callback,
+            app);
+    }
+
+    submenu_set_header(app->submenu, "Quick access app:");
+    submenu_set_selected_item(app->submenu, app->settings.favorite);
+    view_dispatcher_switch_to_view(app->view_dispatcher, DesktopSettingsAppViewFavorite);
+}
+
+bool desktop_settings_scene_favorite_on_event(void* context, SceneManagerEvent event) {
+    DesktopSettingsApp* app = context;
+    bool consumed = false;
+
+    if(event.type == SceneManagerEventTypeCustom) {
+        switch(event.event) {
+        default:
+            app->settings.favorite = event.event;
+            scene_manager_previous_scene(app->scene_manager);
+            consumed = true;
+            break;
+        }
+    }
+    return consumed;
+}
+
+void desktop_settings_scene_favorite_on_exit(void* context) {
+    DesktopSettingsApp* app = context;
+    submenu_clean(app->submenu);
+}

applications/desktop/desktop_settings/scenes/desktop_settings_scene_start.c

@@ -0,0 +1,53 @@
+#include "../desktop_settings_app.h"
+#include "applications.h"
+
+enum DesktopSettingsStartSubmenuIndex {
+    DesktopSettingsStartSubmenuIndexFavorite,
+    DesktopSettingsStartSubmenuIndexPinSetup,
+};
+
+static void desktop_settings_scene_start_submenu_callback(void* context, uint32_t index) {
+    DesktopSettingsApp* app = context;
+    view_dispatcher_send_custom_event(app->view_dispatcher, index);
+}
+
+void desktop_settings_scene_start_on_enter(void* context) {
+    DesktopSettingsApp* app = context;
+    Submenu* submenu = app->submenu;
+
+    submenu_add_item(
+        submenu,
+        "Favorite App",
+        DesktopSettingsStartSubmenuIndexFavorite,
+        desktop_settings_scene_start_submenu_callback,
+        app);
+
+    submenu_add_item(
+        submenu,
+        "PIN Setup",
+        DesktopSettingsStartSubmenuIndexPinSetup,
+        desktop_settings_scene_start_submenu_callback,
+        app);
+
+    view_dispatcher_switch_to_view(app->view_dispatcher, DesktopSettingsAppViewMain);
+}
+
+bool desktop_settings_scene_start_on_event(void* context, SceneManagerEvent event) {
+    DesktopSettingsApp* app = context;
+    bool consumed = false;
+
+    if(event.type == SceneManagerEventTypeCustom) {
+        switch(event.event) {
+        case DesktopSettingsStartSubmenuIndexFavorite:
+            scene_manager_next_scene(app->scene_manager, DesktopSettingsAppViewFavorite);
+            consumed = true;
+            break;
+        }
+    }
+    return consumed;
+}
+
+void desktop_settings_scene_start_on_exit(void* context) {
+    DesktopSettingsApp* app = context;
+    submenu_clean(app->submenu);
+}