Two changes suggested by @Floessie, #5404
This commit is contained in:
@@ -264,9 +264,9 @@ bool ProfileStore::parseDir (Glib::ustring& realPath, Glib::ustring& virtualPath
|
||||
int ProfileStore::findFolderId (const Glib::ustring &path) const
|
||||
{
|
||||
// initialization must have been done when calling this
|
||||
for (std::vector<Glib::ustring>::const_iterator i = folders.begin(); i != folders.end(); ++i) {
|
||||
if (*i == path) {
|
||||
return i - folders.begin();
|
||||
for (size_t i = 0; i < folders.size(); ++i) {
|
||||
if (folders[i] == path) {
|
||||
return i;
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -147,7 +147,7 @@ void ProfileStoreComboBox::updateProfileList ()
|
||||
Gtk::TreeIter ProfileStoreComboBox::findRowFromEntry_ (Gtk::TreeModel::Children childs, const ProfileStoreEntry *pse) const
|
||||
{
|
||||
|
||||
for (const auto iter : childs) {
|
||||
for (const auto& iter : childs) {
|
||||
const Gtk::TreeModel::Row row = *iter;
|
||||
// Hombre: is there a smarter way of knowing if this row has childs?
|
||||
const ProfileStoreEntry *pse_ = row[methodColumns.profileStoreEntry];
|
||||
|
Reference in New Issue
Block a user