Two changes suggested by @Floessie, #5404

This commit is contained in:
Ingo Weyrich
2019-08-16 17:12:20 +02:00
parent 80c3eb6ac3
commit 8cb5ed4d0c
2 changed files with 4 additions and 4 deletions

View File

@@ -264,9 +264,9 @@ bool ProfileStore::parseDir (Glib::ustring& realPath, Glib::ustring& virtualPath
int ProfileStore::findFolderId (const Glib::ustring &path) const
{
// initialization must have been done when calling this
for (std::vector<Glib::ustring>::const_iterator i = folders.begin(); i != folders.end(); ++i) {
if (*i == path) {
return i - folders.begin();
for (size_t i = 0; i < folders.size(); ++i) {
if (folders[i] == path) {
return i;
}
}

View File

@@ -147,7 +147,7 @@ void ProfileStoreComboBox::updateProfileList ()
Gtk::TreeIter ProfileStoreComboBox::findRowFromEntry_ (Gtk::TreeModel::Children childs, const ProfileStoreEntry *pse) const
{
for (const auto iter : childs) {
for (const auto& iter : childs) {
const Gtk::TreeModel::Row row = *iter;
// Hombre: is there a smarter way of knowing if this row has childs?
const ProfileStoreEntry *pse_ = row[methodColumns.profileStoreEntry];