8739 Commits

Author SHA1 Message Date
Lawrence Lee
1b06cb9999 Limit preview refreshing in control line edit mode
Previously, changing values in the camera-based perspective correction
tool while in control line edit mode resulted in the preview being
refreshed. This is unnecessary because all perspective transformations
are disabled in edit mode. This commit disables preview refreshing for
camera-based perspective adjustments in edit mode.
2020-06-24 17:06:21 -07:00
Lawrence Lee
d76cf5cdae Make control lines hidden when switching mode
The program now exits control line editing mode when the perspective
correction method is switched out of camera-based mode.
2020-06-24 16:20:03 -07:00
Lawrence Lee
8d7a5546e1 Add separators in camera-based persp correction
Horizontal lines to separate the sliders, control lines buttons, and
automatic buttons.
2020-06-23 22:33:08 -07:00
Lawrence Lee
afc3edae26 Make control line correction keep old values
Perspective correction through control lines will no longer modify any
parameters if there are not enough lines to do any correction.
2020-06-23 22:24:27 -07:00
Lawrence Lee
9a40c14858 Make proper use of minimum control line count
When using control lines for perspective correction, set the number of
vertical and horizontal lines to the proper values instead of
hard-coding them to 4. The minimum line count is set to 2 when using
control lines, and defaults to 4 when using fully-automatic correction.
2020-06-23 21:57:10 -07:00
Lawrence Lee
6c59f0586f Fix minor memory leaks 2020-06-11 12:41:43 -07:00
Lawrence Lee
24681f324c Remove unneeded code 2020-06-10 16:53:33 -07:00
Lawrence Lee
72d390e99a Add button for deleting all control lines 2020-06-10 16:16:40 -07:00
Lawrence Lee
a120b304f1 Add tooltip for control lines 2020-06-10 13:13:18 -07:00
Lawrence Lee
976cf4c103 Make control lines buttons disabled in batch mode 2020-06-10 12:57:08 -07:00
Lawrence Lee
11459a8bb1 Add label for control lines buttons 2020-06-10 12:50:14 -07:00
Lawrence Lee
72b69b3249 Fix a few small control lines bugs 2020-06-10 12:35:53 -07:00
Lawrence Lee
dd4364fab3 Add buttons for switching control line type 2020-06-10 11:41:15 -07:00
Lawrence Lee
5e5a86f513 Add icons for perspective control line buttons 2020-06-09 16:29:57 -07:00
Lawrence Lee
6b7c1871b9 Implement basic perspective control lines (WIP) 2020-06-08 18:21:12 -07:00
Lawrence Lee
852b3270e1 Make history message key names more descriptive
Use keys that are more descriptive than "HISTORY_MSG_###".
2020-05-04 18:15:27 -07:00
Lawrence Lee
fb5094b6f9 Merge from branch 'dev' 2020-05-04 14:07:45 -07:00
Thanatomanic
1beb3c91b4
Adjust white-point for Nikon COOLPIX P1000. Fixes #5734 2020-04-27 18:13:47 +02:00
Thanatomanic
276ae214f2 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into dev 2020-04-23 10:12:49 +02:00
Thanatomanic
687217a6af Brighten the diagonal line in curves, tone down the gridlines. Fixes #5687. 2020-04-23 10:10:42 +02:00
Ingo Weyrich
d165a08e36 revert a801d76, fixes #5716 2020-04-20 13:43:08 +02:00
rom9
22eee9787e
Film negative stable multipliers (#5485)
* Added new feature to calculate channel multipliers from crop area. This also saves the crop area channel medians to the processing profiles, in order to get a more consistent color balance when batch-applying the same profile to multiple pictures from the same film roll.

* Fixed wrong initialization of array, and missing check for the result of `getFilmNegativeMedians()`.
Moved `ImProcCoordinator::translateCoord()` from private member to anonymous namespace.
Fixed some whitespace and formatting issues.

* Fixed some formatting issues

* Passed `ipf` parameter as const in `translateCoord`.
Narrowed `using namespace` to single class `Coord2D`.

* Added `scaleGain` entry to thumbnail metadata file, to make `scale_mul` multipliers available in thumbnail processing phase. This simplifies multiplier calculations, so that "faking" thumbnail multipliers in the main image processing is not necessary anymore. This way, output values are immune to slight variations of multipliers between successive shots taken with in-camera AWB turned on.
Shifted multipliers so that the output channel medians are balanced when "Camera WB" is selected. This way, just computing multipliers from crop and setting "Camera WB" (which is the default) gives a pretty well balanced image as a starting point.

* New channel scaling method, based on a film base color sample instead of crop area channel medians. Channels are scaled so that the converted film base values are equal to 1/512th of the output range (65k). This giver better black levels in the output, and more consistency when batch-processing multiple negatives.
The output is now compensated for a known fixed WB value, so that the film base will appear grey when WB is set to 3500K, Green=1.
Added PPVERSION 347 to preserve backwards compatibility: when a processing profile saved by RT 5.7 is loaded (PPVERSION=346), the new fields are initialized to the special value -1, which will instruct the main processing to follow the old channel scaling behaviour. The old channel scaling multipliers will then be converted to the new film base values so that the resulting image is the same, and the fields will be overwritten as soon as the PP is saved again. This will transparently upgrade the processing profile.
When the new behaviour is used, but the film base values are still unset, they are estimated based on channel medians, excluding a 20% border around the image. This should give a better result out-of-the-box for pictures containing a large film holder.

* Code cleanup from review

* Run astyle on film neg source files

* Fixed automated build failure caused by incompatible libraries on my dev PC.

* Simplified `Thumbnail::processFilmNegative` method signature. There is no need to pass in `rmi`,`gmi`,`bmi` multipliers from the caller, i can do the same with my own internal multipliers.

* Added `FilmNegListener` class to pass estimeted film base values to the GUI after first processing. Removed old `filmBaseValues` instance variable from RawImageSource.

* Code cleanup

* Forgot to set baseValues flag in `PartialPasteDlg::applyPaste`
Fixed `filmBaseValuesLabel` not updating when reading zero baseValues. Normally not needed (the label is updated later by the listener), but when the user is browsing through pictures the listener won't fire, so the label must be updated to show values are unset.

* Overwritten channel scaling multipliers by calling `get_colorsCoeff` with `forceAutoWB=false`.
Initially, in `RawImageSource::load`, channels are auto-balanced by averaging the whole picture when computing multipliers.
This can give different multipliers for multiple shots of the same camera, which will lead to inconsistent conversions when batch-processing multiple negatives.
This commit re-sets `scale_mul`, `ref_pre_mul`, etc., in order to "undo" the auto-WB and use the normal camera multipliers.

* Found an easier way to get stable overall multipliers, removed the (horrible) on-the-fly mutation of scaling instance variables.
2020-04-13 17:20:56 +02:00
Ingo Weyrich
996ba0a9a3 Partial decoding or wrong dimensions of X-T30 files, fixes #5709, code taken from ART 2020-04-13 13:31:06 +02:00
Thanatomanic
9cc744b1f6 Reset all options in crop. Fixes #5138 and #5045 2020-04-13 11:40:28 +02:00
Desmis
1c63d75399
Merge pull request #5702 from Beep6581/wavtm
Wavelet - added chrominance denoise to wavelet levels
2020-04-08 09:01:03 +02:00
Desmis
4c0013b461 Wavelet final - Change guidefilter parameters 2020-04-08 07:42:17 +02:00
Desmis
cbac4e0691 Fixed segmentation fault with blur levels 2020-04-07 10:52:08 +02:00
Desmis
abba1bf360 Improve enabled blur level and wavelet decomp level 2020-04-07 10:16:08 +02:00
Desmis
ded866f5af Optimize memory when denoise chroma is not used 2020-04-06 17:33:01 +02:00
Desmis
9f5e81b026 Change tooltip offset 2020-04-06 09:42:46 +02:00
Desmis
31355ca70e Added equalizer denoise luminance 2020-04-06 09:37:37 +02:00
Desmis
1e3870d8f7 Clean code improcfun.h 2020-04-05 15:53:05 +02:00
Desmis
f4a28b730a Disabled denoise chrom when denoise and refine disabled 2020-04-05 14:53:55 +02:00
Desmis
93284afafd merge with dev 2020-04-05 14:34:56 +02:00
Flössie
15db8cdb57 Guard accesses to Crop::crop_ratios (#5701) 2020-04-05 11:26:47 +02:00
Desmis
ca8399bc90 change labels 2020-04-05 11:13:18 +02:00
Desmis
05250a2497 Change labels chroma 2020-04-05 11:04:01 +02:00
Desmis
2d52fbdcef Improve wavelet levels with denoise chroma 2020-04-05 10:28:45 +02:00
Desmis
df92c743a6 merge with dev 2020-04-05 07:00:39 +02:00
Desmis
d0e65ec93c Change history_msg 2020-04-05 06:59:17 +02:00
Desmis
2b230bfd1e
Merge pull request #5700 from Beep6581/wavtm
Wavelet - change labels et tooltip
2020-04-05 06:54:23 +02:00
Desmis
7d8e0abd2f Clean code and change default values 2020-04-04 15:37:22 +02:00
Desmis
d00ec5a1b2 Change tooltip and history msg damper 2020-04-04 08:32:34 +02:00
Desmis
bf9089ba61 merge with dev 2020-04-03 07:47:32 +02:00
Desmis
ac0d54ef3e Display pyramid mea[] 2020-04-03 07:37:16 +02:00
Flössie
8886402e93 Fix Clang-10 warnings 2020-04-02 13:23:57 +02:00
Desmis
61c6b19533 GUI for wavelt denoise chroma 2020-04-02 12:32:29 +02:00
Desmis
ed57e3163e Prepare ftblockdn to chroma denoise 2020-04-02 09:10:33 +02:00
Desmis
29596bb457 change reset value slider bluwav to 1 2020-04-01 10:16:24 +02:00
Desmis
310faf33e3
Merge pull request #5695 from Beep6581/wavtm
Wavelet Improvment contrast threshold to prevent fine texture and noise
2020-03-31 16:43:35 +02:00