12468 Commits

Author SHA1 Message Date
Lawrence37
3c21dca522
Merge pull request #7253 from digitalcarp/framing
Add Framing Tool
2024-12-18 22:16:28 -08:00
Lawrence37
9fbdc25245
Merge pull request #7258 from Lawrence37/raw-dehaze-crash-fix
Multi-frame image crash fix
2024-12-14 12:46:48 -08:00
Lawrence37
31e90afe22
Merge pull request #7254 from Lawrence37/ilce-7m3-black-level
Sony ILCE-7M3 (and other Sony cameras) black level
2024-12-14 12:46:01 -08:00
Lawrence37
f2fe3bffe5
Merge pull request #7249 from Lawrence37/canon-r8-masked-area-fix
Canon R8 electronic shutter black level fix
2024-12-14 12:44:55 -08:00
Lawrence37
598ec01b3b
Merge pull request #7269 from Benitoite/patch-45
macOS CI: upgrades x86_64 runner to macOS 13
2024-12-14 11:46:11 -08:00
Richard E Barber
e6e3d95bb4
macOS CI: upgrades x86_64 runner to macOS 13 2024-12-13 07:05:26 -08:00
Daniel Gao
f8cde10662 Fix missing min frame border
* Previously only considered min border if the current border is smaller
* Need to consider as long as min size is enabled
2024-12-06 22:16:27 -05:00
Daniel Gao
a54aacca3f Switch framing tool events to use event mapper
* Removed hard coded events from ProcEventCode and RefreshMap
* Change HISTORY_MSG_* to HISTORY_MSG_FRAMING_*
2024-11-30 15:03:14 -05:00
Daniel Gao
d3962c7e56 Fix framing tool issues
* Print messages only in verbose mode
* Linearize 8-bit values to 16-bit values properly
* Fix memory leak
2024-11-30 14:31:18 -05:00
Daniel Gao
f983da5d16 Fix bugs in framing tool sizing
* Rework uniform relative size calculations
* Fix minimum size requirements not being respected
* Fix typo in framing tool keylib value
* Drive-by code formatting changes
2024-11-30 13:55:52 -05:00
Lawrence37
b0117b7a60
Merge pull request #7246 from Lawrence37/offset-time-default
Include offset times in default EXIF tags
2024-11-24 16:13:23 -08:00
Lawrence37
082d9ff4e8
Merge pull request #7242 from Lawrence37/batch-exif-reset-fix
Fix for all EXIF data getting selected
2024-11-24 16:12:55 -08:00
Lawrence37
9774355960
Merge pull request #7240 from Beep6581/se-exposure-cbdl-dehaze-crash-fix
Fix for crash with Haze Removal, CBDL, and Selective Editing Exposure
2024-11-24 16:12:34 -08:00
Lawrence37
74adad2c8c
Merge pull request #7239 from Beep6581/channel-mixer-deactivated-fix
Fix for channel mixer deactivation
2024-11-24 16:11:52 -08:00
Lawrence37
98136d3738
Merge pull request #7235 from Lawrence37/fftw-blur-radius-fix
FFTW blur radius fix
2024-11-24 16:10:38 -08:00
Lawrence37
df5f1b31f7
Merge pull request #7231 from Beep6581/ukrainian
Ukrainian translation
2024-11-24 16:06:52 -08:00
Lawrence37
7d0ce2fbee
Merge pull request #7224 from Lawrence37/rank-reset-fix
Fix for rank, color label, and trash status reset
2024-11-24 16:06:34 -08:00
Lawrence Lee
2a6b79fb0c
Fix crash when opening multi-frame images
Fix source of raw data when calculating raw minimum values for raw
de-haze.
2024-11-24 12:04:54 -08:00
Lawrence37
3e8d581194
Merge pull request #7178 from Pandagrapher/patch_editwidgets
Allow using more than 255 Edit Widgets for locallab
2024-11-23 12:44:07 -08:00
Pandagrapher
77fefe90b3 Fix for review remarks 2024-11-23 18:07:13 +01:00
Daniel Gao
45bde1c999 Add uniform relative sizing method to framing tool 2024-11-18 15:33:55 -05:00
Daniel Gao
bbb3efd81d Fix resize scale adjustment with framing 2024-11-18 15:33:55 -05:00
Daniel Gao
57ef07f3f6 Improve framing tool usability
* Rename "Resize" to "Resize & Framing" from discoverability
* Add ColorPreview class for displaying a solid color
* Add border color preview
2024-11-18 15:33:55 -05:00
Daniel Gao
2458ba4a29 Fix missing FramingParams equality check in ProcParams 2024-11-18 15:33:55 -05:00
Daniel Gao
4358c2d7a6 Fix computation errors in framing tool
* Compute image aspect ratio if required instead of leaving at 0
* Fix divide by zero error in computing framed size
* Compute resize scale based on original crop
* Reword "Current" aspect ratio to "As Image"
2024-11-18 15:33:55 -05:00
Daniel Gao
55480f40ea Fix framing tool batch mode behavior
* Add adjuster add/set options to preferences
* Update width/height limits
* Trim adjuster values
* Batch mode fixes
  * Display all settings with sensitivity
  * Add "(Unchanged)" option to combo boxes
  * Fix checked button toggle modes
2024-11-18 15:33:55 -05:00
Daniel Gao
7ccab91434 Implement drawing border for framing tool
* Draws border after all resize operations are complete
* Update the RGB sliders for 16-bit channels
2024-11-18 15:33:55 -05:00
Daniel Gao
a96dc4cdde Calculate required image and frame sizes
* Refactor simpleprocess.cc to be more clear on resize dimensions
* Implement image and frame sizing calculations
* Resizes the image based on adjusted framing calculations
* Missing functionality to draw border around image after resizing
2024-11-18 15:33:54 -05:00
Daniel Gao
b88ad569c2 Tweak framing tool GUI
* Set sensitivity of aspect ratio and orientation combo boxes
* Sensitivity determined by absolute/relative sizing method
* Show allow upscaling box for BBOX framing method
2024-11-18 15:33:54 -05:00
Daniel Gao
29945f4a35 Implement ProcEvents for framing tool
* Add new events to ProcEvents
* Add new events to refresh map under RESIZE category
* Add new strings for displaying events in history panel
* Hook up GUI events with emitting ProcEvents
2024-11-18 15:33:54 -05:00
Daniel Gao
757a0a032a Implement partial profile for framing tool
* Update partial profile load/save GUI to include framing tool
* Allows for loading/saving framing tool parameters from the clipboard
2024-11-18 15:33:54 -05:00
Daniel Gao
114a4680de Implement FramingParamsEdited operations
* Implements edited param manipulation operations for framing tool
2024-11-18 15:33:54 -05:00
Daniel Gao
d1148539bb Implement load/save for FramingParams
* Implement writing FramingParams to keyfile
* Implement reading FramingParams from keyfile
2024-11-18 15:33:54 -05:00
Daniel Gao
8e68eccb85 Add framing tool ProcParams
* Adds FramingParams parameter struct to ProcParams
* Implement saving and writing to struct from framing tool GUI
2024-11-18 15:33:53 -05:00
Daniel Gao
b472fbf2ab Add RAII listener blocking utility
* Added for ToolPanel listener and Adjuster
* Follows style of ConnectionBlocker for sigc::connection
2024-11-18 15:33:53 -05:00
Daniel Gao
03a73eb3a4 Add framing tool GUI
* Added under the Resize tool like PR sharpening
* Adds FramingParams and FramingParamsEdited structs
* No parameter read/write implemented
* No support for batch mode
* No adjuster listeners implemented
* Signals and callback functions are defined but do nothing
2024-11-18 15:33:53 -05:00
Daniel Gao
96ad7051cf Refactor aspect ratios out of crop.cc 2024-11-18 15:33:53 -05:00
Lawrence Lee
0051a4cd95
Fix Canon R8 black level with electronic shutter
Remove bad pixels from the masked areas. The top ~40 rows are slightly
brighter than the rest, and the remaining rows at the top near the
center are brighter too (not as bright as the top 40 rows though).
2024-11-16 12:21:44 -08:00
Lawrence Lee
31076f0a62
Fix dcraw reading of black level for Sony
Don't set black level from tiff_bps if a black level is in the metadata.

Remove the Sony ILCE-7M3 black level from camconst.json. The black level
is in the metadata (512 for ISOs < 128000, 1024 for ISOs >= 128000).
2024-11-16 12:11:49 -08:00
Desmis
b73840cf3c
Gamut compression - reduce artifacts resulting from out of gamut (#7205)
* First functions needs for ACES

* New file GUI compressgamut

* GUI first step

* GUI first step

* Gui step 2

* GUI procparams and paramsedit

* GUI read

* GUI step 4

* GUI step 5

* First tooltip

* Gamut compression tooltips

* Various GUI improvment

* History msg

* Comment code with Aces remarks

* First change improccoordinator and events

* Save work on matrix

* Compress gamut next work

* First try gamut compress

* Replace cout by printf in invertmatrix

* Change tooltips and events

* Added namespace std to iplab2rgb

* Comment code

* Active rtthumbnail

* Change tooltip

* Various improvment GUI and rolloff

* Added adobeRGB gamut

* Appimage windows yml

* Remove rttumbnail gamutcompr

* Change event to COMPR

* Change tooltip and verbose

* Restore raw de-haze history message

* Refactor ACES gamut compression functions

* Fix gamut compression color space history message

Correctly display the color space name.

* Add "unchanged" for gamut compression color space

Allow "unchanged" in batch mode.

* Fix gamut compression yellow distance for batch

* Update copyright for gamut compression GUI

* Fix gamut compression color space names

* Refactor gamut compression code

* Remove comment rtthumnail.cc - Acesp1 default

* Change matrix DCI-P3 - threshold maximum to 1 in GUI and in gamut compression - tooltips

* Change tooltip

* Clean code - change tooltips

* Remove appimage windows yml

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2024-11-14 13:08:52 +01:00
Desmis
691fe80896
Revert "Generalized Hyperbolic Stretch in Selective Editing (#7210)" (#7250)
This reverts commit 16db6186ddf4f1d8e2cc0c6d744071ce1195163d.
2024-11-14 10:29:29 +01:00
Desmis
16db6186dd
Generalized Hyperbolic Stretch in Selective Editing (#7210)
* GHS GUI first step

* GHS GUI first step

* GUI step 3

* Hide show ghsmethod

* Siril functions for ghs

* Init ghs in iplocallab

* ghs step 2

* ghs step 4

* Comment copyright Pixlnsight 2021

* Smooth highlights and tooltips

* Enabled saturation and luminance ghs mode

* First tooltip

* Ghs tooltips

* Remove wrong packstart inverssh

* Change labels and tooltips

* Disabled mask in global and other improvments

* Comment code

* appimage and windows yml ghs

* Change tooltip

* Ghsmethod hue and change tolltips

* Change tooltip

* Inverse Stretch step 1

* Inverse GHS

* GHS tooltips

* Change tooltips

* Change tooltip

* Linear black point

* Small change to blackpoint

* Change tooltip

* Clean and comment code

* forgotten GHS highlight attenuation msg in history

* Comment code with Transformation equations

* Change tooltip

* Wrong default value balck point

* Comment code iplocallab

* Ghs curve step 1

* GHS curve step 2

* Show GHS setting in a Curve Box

* Tooltip for ghs S curve

* Disabled warning in compilation simpleprocess

* Simplified code part 1

* Simplified code GHS graph part 2

* Improve black point with negatives values

* Improve BP and tooltip

* Listener enable only with GHS

* White point for GHS

* Change label and tooltip

* Improve behavior white point and black point

* Link sliders ghs_SP ghs_LP ghs_HP and change code to avoid balck screen

* hide unused button in diagonal curve GHS

* prevents the GHS representation in S from displaying artifacts if ghs-d=0

* Change tooltips

* Improvment and tooltips

* Forgotten tooltip

* Improve GUI GHS S curve - change tooltips

* Set transition gray areas in S curve GHS with values of the RT-spot

* Change label GHS

* setlogscale blackpoint and symmetry

* Set recursive reference enable by default in controlspotpanel

* Change lastlocalCurvesDir Dirghs in locallabtools and options - change labels

* Added in converttonormal ghsMode.. not sure if this is useful

* DIY to make GHS curve work without the choices

* Change RGB calculation with luminance function working profile

* 5 modes GHS method

* Label to show datas clipped Black point and White point

* Various change white point tooltips

* Bad behavior wp bp labels

* Small change to improccordinator call to ghschanged ghsbwchanged

* Set log scale ghs_D

* Hide Graduated filter if GHS enable

* Luminance Lab in ghsmethod

* Lab slope factor step 1

* Slope and Chromaticity GHS improvments

* Fixed bad sqrt line 17477 iplocallab

* Workaround linear GHS - re-enable Graduated filer GHS

* Change limits slope lab factor

* Ghs chromaticity Lab (Lch)

* Improve ghs chromaticity

* Change labels and tooltips Lab chroma

* Slope Lab to 100

* Noise and saturation RGB

* Saturation RGB standard and labels

* Change histogram and navigator panel without gamma when using working profile

* Remove gray in GHS curve

* Local contrast a minima

* Regularization stretch

* Improve Graduated Filter in all cases GHS Color and Light etc.

* Improves nlmeans to reduce noise after GHS

* Change to GF - tooltip Nlmeans

* Added oW oH tW tH etc.

* Added call GF

* tX tY for previewProps

* Comment code GF

* Improve local contrast ghs

* Change norm to norm2

* Improve GUI mode complexity and Lab GHS

* Show values BP WP in GUI

* Labgrid ghs step 1

* Labgrid for simulation GHS - step 2

* More points for Labgrid ghs

* Clean and comment code

* Fixed crash in inverse GHS white point - set to 10 points for GSH simulation

* Change to black point in inverse GHS

* Intilialize simulation with nothing if new spot

* Remove curve GHS - optimize code simulation - improve GUI

* set ghs default - fixed crash is case HP SP LP

* Fixed crash - I hope in inverse GHS

* Simplify WP and BP limits to avoid crash in inverse GHS

* Clean code with ghscurve - ghsshape

* Change tooltips

* Change to D - GUI - comment code

* Simulation with 4 more points

* Best simulation with point 0.05 and 0.95

* Clean code - change for crsah in Inverse GHS

* Show values WP and BP
2024-11-13 08:23:41 +01:00
Lawrence Lee
d2e2f0f839
Add offset times to default selected EXIF 2024-11-10 17:32:28 -08:00
Lawrence Lee
7bc69bc5dd
Fix EXIF when resetting history with batch edit
Resetting the history to the first entry in the batch edit tab caused
all the EXIF keys to become selected. There should be no modifications
to the selection because EXIF editing is not available in batch edit
mode.
2024-11-09 21:14:40 -08:00
Lawrence37
bc2fbfad66
Merge pull request #7212 from Lawrence37/canon-burst
Support for images with more than 6 sub-frames
2024-11-08 22:01:58 -08:00
Lawrence37
24214fbd57
Disable exposure Laplacian when CBDL enabled
Avoids crashes due to NaNs.
2024-11-05 23:14:39 -08:00
Lawrence37
3347569d88
Fix channel mixer deactivation
The channel mixer deactivates when the primary values are set to 10.
2024-11-05 22:35:42 -08:00
Lawrence Lee
9b16f407aa
Fix blur radius when using the Fourier method
Fix the formula, adapt old pp3s, and change the maximum blur radius
where applicable.
2024-10-27 18:45:58 -07:00
Lawrence37
ca329d9013
Merge pull request #7220 from pano9000/patch-1
Fix duplicate tag in Deutsch locale
2024-10-26 12:23:56 -07:00
Lawrence37
a924a81b31
Merge pull request #7215 from Lawrence37/pixelshift-ilce-7cr
make_arq and Sony ILCE-7CR Pixel Shift support
2024-10-26 12:23:25 -07:00