91 Commits

Author SHA1 Message Date
Scott Gilbertson
9e310b7454 Minor changes per feedback in issue #6915 (mostly code formatting) 2024-01-10 18:47:14 -05:00
Scott Gilbertson
c918de3178 Reversed %p and %P processing cases for location templates, which were opposite to what the help says. 2024-01-07 11:49:19 -05:00
Scott Gilbertson
0127b68bdb Minor comment clarification 2024-01-07 11:14:52 -05:00
Scott Gilbertson
df41028468 On Windows, use backslashes in template-generated paths
(but continue to accept either / or \ in input strings, on any platform)
Also deleted an unused helper function.
2024-01-07 11:10:05 -05:00
Scott Gilbertson
21c53823ee Reimplemented %p template specifier to use new method, added %P specifier
The %P specifier includes directories from the start of the file path,
whereas the original %p specifier includes them from the end. In both
cases N is from the last directory in the path, and -N is from the
first directory in the path (N=1..9).
2024-01-06 18:21:59 -05:00
Scott Gilbertson
b8d3f90ca0 Reimplement template %dN specifier, making %d-N count from start of path, not end
Also made %pN selectively skip the next character only if it's a slash or backslash,
so for example %p2/a, %p2\a and %p2a produce the same result.
2024-01-06 18:01:56 -05:00
Scott Gilbertson
587e0c6782 Simplified BatchQueue::updateDestinationPathPreview after noticing that calcAutoFileNameBase handles all cases 2024-01-06 16:32:14 -05:00
Scott Gilbertson
380d964077 Add destination path preview label to batch queue panel.
Label initially says "Destination path for the first selected image appears here"
so the feature is discoverable. Select a file and it shows the destination path
that would be used if it is the first file to be processed and the file does
not already exist. Label is updated as the template is edited, so you can see the
effect of the edits. If "Save to folder" is selected, the previewed path uses
that folder.
2024-01-06 16:00:19 -05:00
Stephen Shkardoon
23f2a2fc9f Use _WIN32 instead of WIN32 to detect Windows
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here.
http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
2023-08-13 17:09:49 +12:00
Flössie
a07c38f405 Support for saving TIFFs as BigTIFF (#6690) 2023-03-01 12:47:55 +01:00
Floessie
1318935a87
Better handle thumbnail generation of extreme aspect ratio images (fixes #3794)
* Backport fix taken from ART
* Enforce minimal thumbnail size of 1x1 px in two places, prevents divison by zero and empty image generation
2020-10-25 18:24:30 +01:00
Flössie
79278875da Use snprintf() instead of sprintf() (#5907) 2020-09-15 14:56:57 +02:00
Ingo Weyrich
a5c7713042 Cleanup: removed unused function; also murder instead of call for suicide (delete this) 2020-08-13 13:10:33 +02:00
Ingo Weyrich
79431ffa1d Some changes suggested by @Floessie 2019-11-26 19:42:48 +01:00
Ingo Weyrich
2a4891827d Some cleanups 2019-11-26 15:25:11 +01:00
Ingo Weyrich
587652283d further reduction of include dependencies, also finalised some classes 2019-11-09 16:51:54 +01:00
Ingo Weyrich
962f81f6bc Further reduction of include dependencies 2019-11-01 12:51:08 +01:00
Ingo Weyrich
cac2eb53ef Further reduction of include dependencies 2019-10-31 20:41:08 +01:00
Ingo Weyrich
068847eb5a Further cleanup of include dependencies 2019-10-29 21:06:27 +01:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
Ingo Weyrich
41fc34c5c6 Do not assign empty strings on creation of std::string or Glib::ustring 2019-07-31 20:21:16 +02:00
Ingo Weyrich
cbb3f05b7e use empty() instead of comparison with an empty string 2019-07-22 13:49:08 +02:00
Morgan Hardwood
977af213b9 Queue template parsing OOB access fix by Flössie
https://discuss.pixls.us/t/change-of-queue-output-directory-not-taken-fully-into-account-if-no-f/11975/4
2019-04-02 21:10:16 +02:00
Beep6581
ddd9cd979a
Merge pull request #5237 from lvreclp/batchque_file_overwrite
Fixed file overwrite from queued items
2019-03-24 21:03:39 +01:00
luz.paz
ba840dd260 Misc. typos and whitespace fixes
Found via `codespell -q 3 -I ../rawtherapy-whitelist.txt -S ./rtdata` 
`rawtherapy-whitelist.txt` consists of:
```
adn
amin
autor
ba
byteorder
cas
childs
developpement
dum
foto
fro
inbetween
interm
ist
iten
ith
lonly
nd
ois
optio
preserv
skipp
som
spred
substracted
tbe
tim
uint
unselect
```
2019-03-22 06:38:00 -04:00
Oleg Koncevoy
d2e6a3a44a Fixed file overwite from queued items 2019-03-21 19:32:31 +02:00
Flössie
57d030881d More procparams.h relaxation 2019-03-01 17:40:02 +01:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
Flössie
732bbf1a55 Convert BatchQueue::cancelItems() to functional IdleRegister::add() 2019-01-01 17:55:36 +01:00
Flössie
b08fb04dae Convert almost all IdleRegister::add() calls to add(std::function<>) 2019-01-01 15:53:39 +01:00
Flössie
5af3f64a9d Merge branch 'dev' into review-idle_register-calls 2018-12-31 14:58:26 +01:00
Flössie
00b62d2b65 Add @thirtythreeforty's std::function<> variant (#4892)
Also convert `batchqueue.cc` where applicable.
2018-11-11 20:32:01 +01:00
George Hilliard
cfb61f6fbf Notify GUI when batch starts
Closes #4906
2018-11-01 16:34:28 -05:00
George Hilliard
4a765cc91f Unify inconsistent notifyListener() logic
Previously, this function required a `queueEmptied` bool, which I changed
to `queueRunning`.  But I goofed the logic on this bool; it should
always be "is `processing` nullptr."
2018-10-29 10:52:06 -05:00
Flössie
1d0c128209 Fix Windows build (#4892) 2018-10-28 19:35:31 +01:00
Flössie
5906329485 Review IdleRegister (#4892)
This turns `IdleRegister::add()` into a template function to make the
provided function pointers type safe. It also adds a `delete_data`
parameter to manage the provided data pointer even in `destroy()`.
2018-10-28 13:12:01 +01:00
George Hilliard
8a6e0a7f19 Cleanup from code review 2018-10-26 01:46:30 -05:00
George Hilliard
7d5fe6d1c8 Reenable batch queue interface on queue length notification
This removes the need for canStartNext() to do any UI updates.
2018-10-26 01:18:42 -05:00
Flössie
2125f42116 Turn almost all Listeners into abstract interfaces 2018-10-09 20:32:40 +02:00
Hombre
fe2f45dff2 Merge branch 'dev' into 32b-tiff-output-cli 2018-07-22 18:14:38 +02:00
Morgan Hardwood
522495f4eb Icon cleanup #4469 #3547
Rebased in new branch to cleanup commit history.
2018-07-13 18:13:35 +02:00
Hombre
30efa5930d 16-bit floating-point support for TIFF output image (see #2357) 2018-05-07 09:57:53 +02:00
Hombre
3fe9cae2c3 Merge branch 'tiff32float' into dev 2018-01-08 21:47:14 +01:00
Flössie
e58cecbf06 Try to fix most warnings in the OBS builds (#4284) 2018-01-08 18:17:12 +01:00
Hombre
ee2c8f01e0 Merge branch 'dev' into tiff32float 2018-01-01 15:24:00 +01:00
Alberto Griggio
b589254d21 Moved "Copy metadata unchanged" to PP3, and added "strip metadata" mode
Fixes #3647
2017-12-29 23:03:44 +01:00
Alberto Griggio
bc8b8902e6 make rtengine::processImage return an Imagefloat instead of an Image16
This is for supporting saving to 32-bit float TIFFs
2017-11-20 00:10:51 +01:00
heckflosse
5ddd42f721 Faster png save with still good compression, fixes #4045 2017-11-18 12:56:37 +01:00
Flössie
071e19bfd9 Don't access job in BatchQueue::saveBatchQueue() (fixes #4183) 2017-11-17 16:43:17 +01:00
johenning
06fd003858 Fixed indentation 2017-08-27 21:27:23 +02:00