Commit Graph

438 Commits

Author SHA1 Message Date
Flössie
aeaff29ac0 Apply readability-simplify-boolean-expr 2016-10-12 20:01:30 +02:00
Flössie
19de9d1efa Apply modernize-redundant-void-arg 2016-10-12 18:24:14 +02:00
Flössie
0731975ff0 Apply modernize-use-nullptr
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
Morgan Hardwood
e902091fe9 Fix crash when toggling Before|After view, by Flössie, fixes #3454 2016-10-11 09:46:42 +02:00
heckflosse
b8eb3492c9 colour picker died when crop tool was activated while colour picker was active 2016-10-10 17:10:31 +02:00
heckflosse
0821eea7b6 Cppcheck: Fixed 2 issues introduced with merge of lockable colour picker 2016-10-10 16:28:44 +02:00
Ingo Weyrich
a57ecac9e9 Merge pull request #3452 from Beep6581/cppcheck
merge fixes for a lot of issues reported by Cppcheck
2016-10-09 22:55:31 +02:00
Flössie
d132149a26 Introduce rtengine/noncopyable.hpp 2016-10-08 15:36:44 +02:00
Hombre
e16b2407bd Bugfix: double click to zoom in/out now effective over Pickers
when the Color Picker mode is off.

see issue #1812
2016-10-08 00:44:59 +02:00
Hombre
222b8a7562 Bugfix: Pickers wasn't displayed after a Detail window move
See issue #1812
2016-10-07 14:38:22 +02:00
Hombre
1c8d8c6dce Small code cleanup 2016-10-07 12:48:20 +02:00
Hombre
103091e2c9 Code simplification + bugfix 2016-10-07 02:18:52 +02:00
Hombre
5383a7ab71 Merge branch 'master' into lockable-color-picker 2016-10-07 01:27:33 +02:00
Hombre
773a65b5be Bugfix and using the Navigator's range for displaying values
Thanks a lot to Heckflosse and Floessie for the bugfix
2016-10-07 01:25:45 +02:00
Hombre
f60a4fc4b1 Adding Picker size support and Displayed values support (RGB/HSV/LAB) 2016-10-05 01:13:20 +02:00
heckflosse
18ee91b8e4 Removed rtgui/createicon.cc 2016-10-05 00:04:22 +02:00
heckflosse
e82b60cd03 Cppcheck: Fixed some issues found by Flössie during review of my changes 2016-10-04 23:50:44 +02:00
heckflosse
566d4c9822 Cppcheck: Fixed most issued in rtgui/* 2016-10-04 23:28:19 +02:00
Flössie
162c65e696 Use get_parse_name() in rtgui/dirbrowser.cc (#3444)
This will print the full path and is consistent with the gtk3 branch.
2016-10-04 20:36:28 +02:00
Morgan Hardwood
1c9b84aadb Moved RT.ico from rtgui into rtdata/icons/ 2016-10-03 22:44:13 +02:00
Morgan Hardwood
6d85d35039 Removed non-ASCII characters from code files, closes #3445 2016-10-03 22:05:02 +02:00
heckflosse
3552fd4161 Cppcheck: Fix issues related to explicit constructors 2016-10-03 00:54:02 +02:00
heckflosse
ccd9002c3a Cppcheck: Solve issues related to copy constructor 2016-10-02 23:33:00 +02:00
Hombre
aca00389d9 Solving most if not all bugs left
Still some features to add, but this commit should make this tool fully
usable.
2016-10-02 17:23:09 +02:00
Flössie
ca0afa8d5f Fix incompatibility with glibmm 2.50 (#3440)
Kudos to @Hombre57 for the suggestion.
2016-10-01 12:38:24 +02:00
Hombre
4506247985 Merge branch 'master' into lockable-color-picker 2016-09-30 01:06:19 +02:00
Hombre
f904bc8f84 First patch of the LockableColorPicker tool.
Still Work In Progress, but can be used without too much hassle.
2016-09-30 01:03:57 +02:00
Flössie
8e6cfcb766 Fix use-after-free of ImageArea::mainCropWindow (#3048) 2016-09-29 18:21:37 +02:00
Morgan Hardwood
7d21cbfaa6 Reworked Median (NR) wording, updated RawPedia accordingly. 2016-09-27 23:13:55 +02:00
Hombre
d52b627c68 Merge branch 'origin/navigator-units' 2016-08-31 13:42:56 +02:00
Hombre
f3d46f4c37 Minor code adjustment 2016-08-31 13:40:02 +02:00
Hombre
388d43ebce Adding new units for the RGB and HSV values in the Navigator tool (below
Histogram). Click on one of thes two columns to cycle to a new unit
independantly, between [0-1], [0-255], [%]  (Hue stays in degree instead
of percent). The current unit is saved in Options for new Editor tabs or
between sessions.
2016-08-31 03:58:07 +02:00
heckflosse
6a19178e52 Enable whole area of magnification windows for moving, fixes #3378 2016-08-30 01:53:27 +02:00
Hombre
2ba7e296d0 Bugfix: Options::readFromFile should not reset the options values. They
are initialy set in the constructor then should only be updated by each
call to this method.
2016-08-29 01:35:19 +02:00
heckflosse
cd16b91be0 fixes #3395, unrelated bulk changes cause saturation setting to double its value 2016-08-17 16:15:35 +02:00
Morgan Hardwood
14b5bf1386 Prevents thumbnail race condition, from Floessie in #3304 and fixes #3384 2016-08-06 21:24:36 +02:00
Morgan Hardwood
0608ad8f49 Simplified OS X GIMP and Photoshop calling code. 2016-07-15 01:16:12 +02:00
Morgan Hardwood
cb5e99ef62 Updated defaults for crop, sharpening and post-resize sharpening. 2016-07-10 21:22:12 +02:00
Morgan Hardwood
3aaacf3b0c Made post-resize sharpening RL radius minimum size consistent with RL radius from main sharpening - 0.40. Removed redundant guiutils.h include. 2016-07-10 20:31:03 +02:00
Ingo Weyrich
36f2c4db59 Merge pull request #3375 from Beep6581/fix_all_cppcheck_performance_hints
Fix cppcheck performance hints
2016-07-08 12:42:34 +02:00
heckflosse
c8779c04f5 Fix all - 2 cppcheck performance hints 2016-07-06 13:04:24 +02:00
Morgan Hardwood
3d6f9407a2 Updated help and man page, #3369 2016-07-05 23:07:58 +02:00
heckflosse
90c7407c90 Disable wrong warning for non Windows builds 2016-07-04 19:25:59 +02:00
heckflosse
2710bcdcec Fix a warning and a crash 2016-07-02 23:03:58 +02:00
heckflosse
4236fd0545 Add milliseconds to queue params file, fixes #3363 2016-07-01 13:33:05 +02:00
Beep6581
cbbdc3e36f Rawtherapee forgets checked Autofill-option, fixes #3332 2016-06-09 20:38:46 +02:00
Flössie
8ee8eb4ed6 Another bunch of cleanups
- DCPProfile::apply()
- DCPProfile::makeHueSatMap()
- DCPProfile::hsdApply()
- Refactoring

More to come...
2016-06-07 21:04:12 +02:00
Floessie
e0ca8ecdff First round of cleanups for rtengine/dcp.*
- Sorted functions and methods
- Moved local functions to anonymous namespace
- Slightly modernized local functions
- Reworked `DCPStore` and fixed memory leak

Still coming:
- Rework `DCPProfile`
2016-06-04 22:43:09 +02:00
Flössie
e2a670c992 Fix missing return value in LensGeometry::doDisableAutoFillIfActive()
This should fix #3328.
2016-06-04 17:47:19 +02:00
Floessie
8b5cf386bd Merge pull request #3318 from Beep6581/lcpautofill
Automatically disable Auto-Fill when enabling LCP Disortion Correction, #1791
2016-06-03 19:30:16 +02:00