Commit Graph

10697 Commits

Author SHA1 Message Date
Lawrence Lee
af29bf84e6 Fix cppcheck warnings for uninitialized variables 2020-09-13 12:33:25 -07:00
Lawrence Lee
c03efe4878 Add dedicated buttons for scope switching
Previously, changing to a different scope was done by clicking the scope
type button and cycling through all scopes. This commit decreases the
number of clicks needed to switch between two scopes by adding a radio
selector. The radio buttons can be shown or hidden by pressing the scope
type button. This commit also makes the raw histogram one of the scope
types.
2020-09-12 17:52:24 -07:00
Lawrence Lee
bb0c625960 Use enum for scope types 2020-09-07 16:37:40 -07:00
Lawrence Lee
b2942fd949 Improve performance of scopes
If a scope update is requested, don't recalculate scope data if it is
already up-to-date.

Eliminate double and triple scope rendering.
2020-08-28 22:33:52 -07:00
Lawrence Lee
6d8a31961f Color the vectorscope lines 2020-08-27 16:35:39 -07:00
Ingo Weyrich
6c2463889b Revert "CH vectorscope: speedup by avoiding conversions"
This reverts commit cfc1e66024.
2020-08-20 12:31:37 +02:00
Ingo Weyrich
cfc1e66024 CH vectorscope: speedup by avoiding conversions 2020-08-19 14:00:09 +02:00
Lawrence Lee
350324affc Disable double-clicking of waveform & vectorscopes 2020-08-16 18:08:26 -07:00
Lawrence Lee
371fc65416 Improve type conversions 2020-08-16 16:10:46 -07:00
Ingo Weyrich
e667e3dce7 Removed timing code and some includes 2020-08-16 21:34:11 +02:00
Ingo Weyrich
2858876f44 use array2D.fill() instead of memset() 2020-08-16 17:19:59 +02:00
Flössie
7aa6b713c6 Fix vectorscope 2020-08-16 16:01:29 +02:00
Ingo Weyrich
d59f488aea minor fixes 2020-08-16 14:07:25 +02:00
Ingo Weyrich
9e040b3bc2 ImProcCoordinator::updateVectorscope(): parallelize loops 2020-08-16 11:46:17 +02:00
Flössie
3af822b6f7 Fix abuse of array2D<>
- Add copy c'tor and assignment to `array2D<>`
- Use `std::vector<>` instead of smart pointer to array
- Constify a bit
- Make use of `rtengine::max(...)`
2020-08-16 11:22:10 +02:00
Flössie
231c5e2c99 Apply clang-tidy's google-readability-casting
```
clang-tidy-10 -header-filter=.* -p=build -fix -checks=google-readability-casting rtgui/histogrampanel.cc
```
2020-08-16 10:25:22 +02:00
Flössie
c5ace05df8 Merge branch 'dev' into waveform 2020-08-16 10:08:28 +02:00
Floessie
4888cb76f2 Merge pull request #5878 from Beep6581/delayed_connection
Delayed GUI updates
2020-08-16 09:32:53 +02:00
Ingo Weyrich
e67b02da8b further cleanups 2020-08-15 22:36:10 +02:00
Ingo Weyrich
07d26c16ed ImProcCoordinator::updateVectorscope(): fix crash caused by large stack allocation, speedup, fixed scaling from [0;255] to [0;65535] range 2020-08-15 17:35:24 +02:00
Ingo Weyrich
1aa3b5c52b dcraw.cc: fix some warnings 2020-08-14 13:37:59 +02:00
Ingo Weyrich
a4813ac256 RT build on non-Apple systems using clang shows wrong compiler info in AboutThisBuild.txt, fixes #5864 2020-08-14 12:22:08 +02:00
Ingo Weyrich
20f13048d4 Merge pull request #5884 from Beep6581/cleanups_202008
Cleanup: removed unused function; also murder instead of call for sui…
2020-08-13 15:18:09 +02:00
Ingo Weyrich
e19321982c Further cleanup 2020-08-13 13:27:01 +02:00
Ingo Weyrich
1419a01940 Further cleanup 2020-08-13 13:26:27 +02:00
Ingo Weyrich
a5c7713042 Cleanup: removed unused function; also murder instead of call for suicide (delete this) 2020-08-13 13:10:33 +02:00
Flössie
e4d037c7a9 Merge branch 'dev' into delayed_connection 2020-08-10 14:00:37 +02:00
Flössie
a55e06c676 Remove C++14isms from delayed_helper::apply()
Clang to the rescue:
- `void` isn't a literal type in C++11
- calling `f()` from `constexpr` isn't allowed in C++11

So, remove `constexpr` to simplify things.
2020-08-10 13:55:45 +02:00
Desmis
130fbb8eb2 Local complexity - Add 'Basic' to 'Standard'(Normal) and 'Advanced'(Expert) (#5858)
* Mode simple to color and light

* Exposure complex

* Vibrance and SH complex

* Soft and Blur complex

* Common mask complex

* Sharp Retinex complex

* Localcontrast complex

* Change label tooltip complex

* Change labels and tooltip

* Change tooltip french

* Change default value scope TM

* Some forgotten hide..with basic in inverse mode

* Another hide in basic and inverse

* Change some type in labels

* Change typo contrast

* Refine some labels tootips

* Change after review Ingo - thanks

* Improve history behaviour when changing local adjustments complexity mode

* Added normal to original retinex - basic to dehaze

* Fixed bad behavior normal expert Color and Light

* Improve edge sharpness

* Another improvment edge sharpness

* various improvement

* locallab: speedup and reduced memory usage for wavcontrast4()

* remove file

* French labels complexity

* calckoe(): cleanup, speedup and bugfix for 3x3 gaussian kernels

* calckoe(): cleanup for 3x3 gaussian kernels

* calckoe(): fill koeli[] with zeroes if level <= 1 && tloww >= 75.f

* GUI part fixes and cleanup

* Fix in Locallab Settings panel

Additionnal minor fix in Preferences windows

* Change default mode complexity in preferences - basic

* Change complexity in option

* Improve gui when lauch first image

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Pandagrapher <pierre.cab@gmail.com>
2020-08-10 13:18:21 +02:00
Lawrence Lee
e247a1e086 Increase visibility of vectorscope pointer 2020-08-09 18:00:12 -07:00
Lawrence Lee
f7c02af184 Fix rendering of blank vectorscope 2020-08-09 17:22:23 -07:00
Lawrence Lee
8b3af4c520 Fix some cppcheck warnings 2020-08-09 17:16:57 -07:00
Lawrence Lee
6cd87ad975 Use array2D for waveform and vectorscopes 2020-08-09 16:49:28 -07:00
Lawrence Lee
2f06f56d9c Merge from dev 2020-08-08 22:02:29 -07:00
Lawrence Lee
ec27ad4abc Add waveform/vectorscope brightness feature 2020-08-08 17:11:18 -07:00
Lawrence Lee
6c53317ac1 Add pointer indicator for vectorscopes 2020-08-08 13:00:18 -07:00
Lawrence Lee
f779527833 Clip H-C vectorscope according to color profile 2020-08-08 12:37:28 -07:00
Flössie
5e207afff6 Merge branch 'dev' into delayed_connection 2020-08-08 11:23:37 +02:00
Flössie
f353df3d05 Add DelayedCall and integrate it into navigator and histogram
- Rename `delayedconnection.h` to `delayed.h`
- Align `delayed_helper::apply()` with `std::apply()`
2020-08-08 11:18:56 +02:00
Lawrence Lee
698b2e1842 Finish Cairo surface used for waveform 2020-08-07 15:18:02 -07:00
Lawrence Lee
426162f269 Move lightness waveform behind RGB waveform 2020-08-05 12:23:34 -07:00
Lawrence Lee
9a89eb5454 Fix RGB bars not showing for waveform
The bars were not showing if the raw histogram button was activated.
2020-08-05 12:05:58 -07:00
Lawrence Lee
9382306fed Add CIELAB lightness to waveform 2020-08-05 11:57:34 -07:00
Desmis
25c5e62b72 Merge pull request #5873 from Beep6581/wavedg
Wavelet levels - Change labels and tooltip
2020-08-05 17:01:55 +02:00
Desmis
d939ffafdc Change label strength refine 2020-08-05 13:13:18 +02:00
Desmis
9dab7d3541 merge with dev 2020-08-05 10:24:21 +02:00
Desmis
2c3881f3a6 Retinex - Choice complexity Standard - Advanced (#5871)
* Enabled standard advanced for Retinex

* Added forgotten reset button
2020-08-05 10:21:14 +02:00
Lawrence Lee
ba57a6c680 Fix waveform and vectorscope crop behavior
Properly scale values for the vectorscopes and only show the crop region
for the waveform.
2020-08-04 23:07:03 -07:00
Desmis
6e4efb55c1 Change labels and tooltip 2020-08-05 07:13:49 +02:00
Desmis
03faaf94dd merge with dev 2020-08-05 06:54:14 +02:00