Commit Graph

702 Commits

Author SHA1 Message Date
Lawrence
f83a62be5b Add back the old perspective tool
Add perspective correction method chooser to allow choice between the
original perspective tool (simple) and the new one (camera-based).
2019-12-28 17:18:59 -08:00
Lawrence
f514a69104 Group perspective adjusters in frames
Divide perspective correction adjusters into three groups: camera
attributes, post-correction adjustments, and perspective distortion
recovery.
2019-12-27 20:50:18 -08:00
Lawrence
f9a8875bb5 Add more perspective correction adjusters
Add camera lens/sensor shift support with horizontal/vertical shift
adjusters.

Add shifting and rotation of corrected image. This allows
post-correction adjustments to be made more easily given the fixed image
canvas size.

Add scaling of final result. This also helps reduce frustrations with
the fixed image canvas size.

Replace field of view with focal length and crop factor. Use of focal
length and crop factor is more common than diagonal angular field of
view. The new adjusters should be more intuitive for most photographers.
The implementation of perspective correction uses a focal length
relative to the image dimensions. The existing code calculates that
focal length with trigonometry. The new code does it by multiplying
by a ratio.

Replace vertical bias with horizontal and vertical perspective
distortion recovery. Vertical bias is not intuitive as it causes
vertical lines to converge off-center if horizontal correction is
applied. The new adjusters perform perspective distortion on the
projection of the corrected image, allowing vertical/horizontal lines to
converge towards the center lines of the image.

Refactor perspective transformation math to use dynamically computed
homogeneous coordinate matrices instead of pre-calculated formulas. This
should add some overhead, but results in more maintainable code and
possible improved performance due to the reduced number of arithmetic
and assignments needed for each pixel.

Integrate new adjusters in the GUI. This includes fine granularity for
batch processing add/set modes and history.
2019-12-27 16:40:41 -08:00
Lawrence
f4c37598ee Generalize perspective correction
Revise perspective transformation to remove hard-coded angular field of
view and horizontal perspective axis of rotation. Add vertical bias
parameter to retain ability to perform vertical perspective
transformation independent of the horizontal perspective axis of
rotation. Add field of view parameter as a tentative method for
specifying angular field of view.

The current implementation of perspective transformation applies
horizontal perspective transformation in such a way that preserves the
orientation of a horizontal line going through the center of the image.
In common use cases, horizontal lines such as the horizon do not go
through the center of the image. In such cases, the horizontal
perspective axis of rotation should not be parallel to the image's
y-axis. This commit makes the axis of rotation dependent on the vertical
parameter.

The two axes of rotation should be placed at the appropriate distance
from the image in order to prevent stretched or compressed proportions.
In the current implementation, the axes are at a fixed relative distance
from the image. This commit adds the ability to specify the distance in
the form of the diagonal angular field of view.
2019-12-18 10:22:05 -08:00
Morgan Hardwood
164fab28e0 Added Slovenian translation
Translation by Matjaž Jeran / matjazjeran

Closes #5488
2019-12-02 11:25:57 +01:00
Morgan Hardwood
98ac8d5f76 generateTranslationDiffs 2019-12-02 11:24:15 +01:00
Ingo Weyrich
3be7016517 Capture sharpening: Remove range adjuster and introduce 2019-11-13 21:05:24 +01:00
Ingo Weyrich
4857566d25 Capture sharpening: add range label to default file 2019-11-12 18:06:55 +01:00
Ingo Weyrich
174f5e95ff Capture sharpening: revome transations related to gamma! 2019-11-12 00:19:04 +01:00
Ingo Weyrich
5c332663e7 Merge branch 'dev' into flatfield_review 2019-10-26 21:12:23 +02:00
Morgan Hardwood
ff2e5da9e4 generateTranslationDiffs 2019-10-23 20:51:08 +02:00
Morgan Hardwood
dc972ddb21 Film Negative button and tooltip changes 2019-10-23 20:32:41 +02:00
Ingo Weyrich
37e7a705ab Review of flatfield code, own compilation unit, use clip control value 0 when using auto clip control on already clipped image, code review 2019-10-23 20:22:03 +02:00
Morgan Hardwood
6a44170aff Fix shadow/highlight clipping indicator keyboard shortcuts in tooltips
Closes #5493
2019-10-23 18:01:04 +02:00
TooWaBoo
feb2786087 Update Deutsch locale 2019-10-06 03:43:10 +02:00
Morgan Hardwood
984696ed99 generateTranslationDiffs 2019-10-03 10:11:47 +02:00
Morgan Hardwood
9c36345a38 Capture Sharpening history entries 2019-10-03 10:09:13 +02:00
Jala015
8789ef668a Update Portugues (Brasil) 2019-10-02 15:52:09 -03:00
Ingo Weyrich
a11295ef7a Merge branch 'dev' into dehaze_speedup 2019-09-23 20:33:55 +02:00
Ingo Weyrich
57466be795 Capture sharpening: Label and tooltip changes, also renamed key for favorite tab to capturesharpening 2019-09-23 20:33:32 +02:00
Ingo Weyrich
3124e2b801 Merge branch 'dev' into dehaze_speedup 2019-09-23 16:32:48 +02:00
Ingo Weyrich
d1ccf27780 Capture sharpening: add missing history message 2019-09-23 16:32:23 +02:00
Ingo Weyrich
0fc0eced5a Merge branch 'dev' into dehaze_speedup 2019-09-22 15:39:19 +02:00
Ingo Weyrich
7ff3192cc9 dehaze: added lumimance mode from ART, #5456, thanks to @agriggio 2019-09-20 14:03:09 +02:00
Ingo Weyrich
f2cdbd0e4d Capture sharpening: experimental radius offset depending on distance to center 2019-09-16 15:09:47 +02:00
Ingo Weyrich
4079bb9920 Capture Sharpening: automatic radius calculation 2019-09-11 18:56:07 +02:00
Ingo Weyrich
ba43437220 Merge pull request #5445 from Beep6581/capture_sharpening
Merge Capture sharpening into dev to get more tests
2019-09-10 19:27:01 +02:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
Morgan Hardwood
b858bfb2c9 Update "Advanced" tab shortcut to Alt-a
Back when it was called the "Wavelet" tab the Alt-w shortcut was used.

Closes #4322
2019-09-06 22:15:37 +02:00
Ingo Weyrich
7b3c50bc31 Capture sharpening: auto contrast threshold 2019-08-17 15:18:24 +02:00
Ingo Weyrich
8421f8780a capture sharpening: contrast threshold 2019-08-15 20:40:32 +02:00
Ingo Weyrich
506254ce46 capture sharpening: first mockup 2019-08-14 17:19:26 +02:00
Morgan Hardwood
2dee88428f Japanese localization updated by Yz2house, closes #5384 2019-07-21 13:18:31 +02:00
TooWaBoo
b4cb605673 Update Deutsch locale 2019-07-18 17:58:18 +02:00
Morgan Hardwood
a0f2040816 Small cleanup
Removed unused key TP_FILMNEGATIVE_REF_SPOTS.

Style fix in language string.

generateTranslationDiffs

Film Negative values in History use newlines to reduce required width.

Removed benchmark code.
2019-07-17 21:23:17 +02:00
rom9
6e31285d9e Merge remote-tracking branch 'origin/dev' into filmnegative 2019-07-10 21:37:23 +02:00
TooWaBoo
3c18613afb Typo fixed 2019-07-06 14:36:49 +02:00
TooWaBoo
7f5080ded0 Update Deutsch locale 2019-07-06 13:59:31 +02:00
Morgan Hardwood
6fa533c40b Clarify permanent file deletion strings
Closes #5365
2019-07-05 15:30:30 +02:00
rom9
b4c109f275 ProcParams now contain red and blue ratios, to be aligned with values in the GUI. 2019-06-29 16:06:40 +02:00
rom9
63a6e1b79c Changed GUI behaviour so that the first slider sets the reference exponent (green channel), and the other two sliders set the ratio of the red/blue exponent to the reference one. This should be more intuitive, and less confusing when clicking on the reset-to-default slider button. Now the first slider sets the general contrast, while the other two affect the color.
Lowered exponent slider max value from 6 to 4 (it was too large to be useful). New sliders are log-scale.
2019-06-26 02:00:34 +02:00
rom9
8c6458daff Removed "lock channels" CheckButton, it wasn't very useful. Keeping the "(lead)" note on the green channel label, to give a hint that this slider controls the other two as well. 2019-06-21 20:51:50 +02:00
rom9
d01f78864c Locked red and blue exponents by default in the GUI, added CheckButton to unlock them. 2019-06-14 22:14:24 +02:00
rom9
5ddc4a3e0e Added missing checkbox for film negative feature in partial apply / partial paste dialogs. 2019-06-11 22:13:16 +02:00
rom9
9df8008949 Film negative processing: first usable version. Only supports bayer raw files, thumbnails don't work
Added performance improvements suggested by heckflosse. Lowered median sampling step from 7 to 5 since calculation is now much faster.

Added support for Fuji X-Trans raw files.

Applied SSE2 patch provided by @heckflosse, improves performance in main processing loop.

Moved film negative processing stuff in its own compilation unit.

Code cleanup: removed redundant omp directives.

Added check for dead pixels, going above threshold after inversion. ST_BAYER only for now.

Reverted leftover hack in cropwindow.cc
2019-06-08 01:40:29 +02:00
luz.paz
cc60ea2248 Fix source comment and misc. typos
Found via `codespell -q 3 -I ../rawtherapy-whitelist.txt -S ./rtdata/languages -L hist,fo,reall,bloc,alph`
2019-06-03 17:38:50 -04:00
Morgan Hardwood
386ae560b1 generateTranslationDiffs 2019-06-03 14:32:22 +02:00
TooWaBoo
0241179244 Fixed typo "Korreturwert" 2019-05-26 04:30:19 +02:00
TooWaBoo
2643529d9f Update Deutsch locale 2019-05-25 17:27:24 +02:00
Morgan Hardwood
683377e039 generateTranslationDiffs 2019-05-24 16:50:23 +02:00