Commit Graph

11653 Commits

Author SHA1 Message Date
Lawrence37
b7816ff882 Merge pull request #6809 from Lawrence37/external-editor-macos-fix
Fix external editor on macOS
2023-08-06 11:54:52 -07:00
Desmis
8d0333120e Research and development - WB auto -temperature correlation - tests - finding the optimum settings (#6643)
* Change estimchrom estim hue final

* Itcw observer checkbox

* 8 spectral colors

* 11 spectral colors

* 6 spectral colors

* Small change to correction green

* Fixed various bad behavior - settings itcwb_deltaspec

* 4 spectral colors green

* 3 green spectral colors

* 3 spectral colors green

* 5 spectral colors red green

* 3 spectral colors red green

* 3 spectral colrs green red

* Chnage slider choice deltaE - to size color patch

* display more info in console

* Display more info in console - comment code

* Clean - comment code

* 8 spectral colors green red

* 8 spectral colors blue

* 8 spectral colors blue

* 3 spectral colors

* 6 spectral colors

* 4 spectal colors

* 2 spectral colors

* Eliminate high Y - increse temp iteration - recenter selection inside patch

* compatibility 5.9

* Modify dislay and place selected dats in patch

* Dispaly in console hue chroma image selection

* First optimization

* optimization code - clean unused variables

* Remove sorted in chroma order - some others changes

* 5.9 compatibility

* Clean and optimize code

* Clean code - more display info in console

* More info in console - set itcwb_minsize in option

* Display patch chroma in GUI

* Change some default settings

* Minsize patch GUI

* Display GUI patch size

* Chroma patch variations

* Display in GUI min and max dats found in patch

* Some adjustments

* Remove too low datas in patch

* Various improvment - ponderate

* Clean code colortemp comment spectral datas

* Comment code - correc gren

* Comment and refine code

* Fixed bug in improcoordinator

* fixes a malfunction of AWB bias in improcoordinator

* Various improvments - clean code

* 2 improvments green and find patch

* Allows parametrind ponder and Ypurple in options

* Update autowb - filter on magenta purple

* Clean and optimize code

* Read colors in GUI

* Denoise median 5x5 image datas before Itcwb

* Change to GUI

* Replace median5x5 by 2 median3x3 - clean GUI code

* Work around to recalculate wbauto

* Remove work around - change params->wb related change

* Disabled low_sampling 5.9

* First try for compatibility Low sampling 5.9

* Re-enable WB autogrey

* Change reference image to autogrey if camera settings probably out

* Clean code aand adjust settings camera out

* Format astylert rawimagesource.cc - various small adjustments

* Small correction

* Small green correction

* Change default settings - correction to autowb bias in improccoordinator

* Save provisory work

* Save provisory work 2

* Try to find good tempitc with iterate when temptitc very different 5000K

* Change 2 default settings

* Work around awb temp bias

* Limit work around bias - small other changes

* 3 spectral colors deep blue

* 4 spectral color deep blue

* 4 color spectral yellow

* 5 spectral colors neutral red-magenta

* 5 spectral color neutral red magenta

* Change threshold tempitc

* 5.9 compatibility

* Work around bad claculation Planck's formula

* Fixed bad behavior when using blackbody spectal

* 6 spectral color - checkbutton remove 2 passes

* Fixed various bugs

* Format rawimagesource.cc

* Various improvment before to find the good selection

* First new optimization (perhaps?)

* Display GUI patc deltaE

* Various optimzation and tooltip

* Default observer 2°- Simplify GUI - improve display GUI - remove too low numbers datas

* 4 spectral colors - change 2 settings

* Change calculation threshold 2 passes

* 6 spectral colors magenta

* 13 spectral colors

* Improvment GUI display

* remove checkbutton no_purple

* 2 spectral colors - remove in GUI low sampling 5.9

* Change default setting display in console

* Change behavior when temp near stdA

* 4 spectral colors - settings Itcwb_tempstdA

* Gamut control on image histogram

* Clean code and format rawimagesource.cc

* Comment and format colortemp.cc

* Remove unused fileds from GUI - change tooltips

* Add tooltips

* Various changes

* Change settings when camera temperature is out

* improvment extra and tooltip

* Small change when using auto grey as start reference

* Remove itcwb_fgreen from GUI

* Various change - and 'unsatisfactory' test to take into account Custom

* Change second temp when < 4000 - replace automatic by automatic and refinement

* Neutralize 'Use custom tempertaure and green'

* Green refinement

* Clean code - small changes

* Other clean code

* Added forgotten itcw_green in procparams.cc

* Fixed a bug dispaly deltaE

* Change threshold settings - change code for Custom

* various change in case of using camera settings

* Change way to estimate range green

* clean code and message in console

* Clean and optimize

* Disable 2 passes if custom

* Improve GUI 2 passes

* Increase sampling and number of temperature above 9400K

* Hide AWB temperature bais and green refinement when Custom temerature ans green

* marks out the code with past time markers

* Improve time processing with spectral colors temp calculations

* Replace in console msec by nsec

* Scan temp 5.9

* Change max temp and behavior if temp > 15000k

* Refine temp near 14000K

* Increase sampling temperature 132 to 167

* Increase sampling temperature

* Set in preference choice for itcwb_custom

* White point calculated  with observer instead of table

* More on whitepoint calculation - informations

* Clean and format code with astyle colortemp.cc rawimagesource.cc improccoordinator.cc

* Small change tooltip

* Improve update auto-wb

* Remove 'use custom temperature and tin' - simplify sampling to 2 choice

* Small change to rand AWB bias - green refinement - tooltips

* slightly modify the parameters upstream of the algo - do not use camera in some cases

* Mixed initial green

* Refine init green and temp when no camera

* Refine temp and green in do not use camera settings

* Change tint threshold and various improvments (tooltips, wrong values..)

* Refinment and clean code

* Improve mode No use camera settings

* Init nocam

* Refine use no camera  settings

* Small change

* 5.9 compatibility - and format

* Refine sampling temperature  around 7000 - 8000K

* Format astylert rawimagesource colortemp

* 5.9 settings

* 5.9 settings 2

* Various change - 5.9 - format

* Improve pre and post algorithm

* Fixed correction temp > 8000K

* Fixed bad behavior Tppat.minchroma

* Change sampling choices and tooltip

* Change name wp wp2 wip to wb wb2 iwb to avoid misunderstood

* Small Change settings - limit display studgood to 0.0001

* Improvment display GUI temp

* Change default sampling

* Change ACESP0 to JDCmax

* Improve GUI abstract profile

* Allows dispaly in console xy values thanks to Reffort

* Remove bruce rgb in wp and abstract

* Change wp abstract and save itcwb with dispaly cellxy

* Change prim = 13 improccoordinator iplab2rgb

* remove display datas in console - fixed wrong display Y xyY

* Fixed ifferences in GUI maxhist minhist

* Change limits x y in function sampling

* fixed a dizziness

* Change  after algorithm rule when temp > 6000K

* Harmonize limx limy for oldsampling 5.9

* Added Cam xyz matrix to sampling - thanks to Reffort

* Display in console xyz matrix

* Forgotten instruction when mix camera and autowb grey

* Change rgbloc with Camera matrix Dcraw when no input profile

* Change rep to repref in rgbxyz

* Remove message in console

* 5.9 compat

* 5.9 compat 2

* 5.9 compat 3

* 5.9 compat 4

* 5.9 compat 5 format

* 5.9 compta 6

* Improve code

* Diasble itcwb_sampling in GUI

* Comment code

* Clean and comment code

* 5 spectral colors

* 9 spectral colors

* 2 spectral colors

* Various improvments

* 5 spectral colors

* 5 spectral colors

* First changes review lawrence37

* Second changes review Lawrence37

* 3rd changes review Lawrence37

* 4th changes review Lawrence37

* Change windows and appimage yml

* Re-enable Rtv4_Bruce in procparams.cc

* test for 5.9 compatibility

* Try to fixed crash

* Slightly improve the management of 5.9

* test for 5.9 compatibility by passing parameters via the GUI

* Forgotten parameter

* Change ref_spec limit and remove pac_start for itcwb_sampling

* Puts back the old Planck formula - the same as in dev

* Revert "test for 5.9 compatibility by passing parameters via the GUI"

This reverts commit d6b5a8feda31b93a5574cee6ebf4d3e9d58bbcfb.

* Switch to new ITCWB only when changing WB method

Prevents sudden changing of the white balance if ITCWB is selected and
the image is reopened.

* Fix spelling in comment

* Suggested change from Lawrence37 to whitebalance - small change to improcoordinator

* tempbias Set_sentive(false) if itcwb_smapling - clean whitebalance

* Another clean whitebalance.cc

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2023-08-06 13:44:48 +02:00
Jean-Christophe
00fff386c7 Merge pull request #6722 from hfiguiere/crop-leak-6721
Issue #6721 - Fix memory leak in Crop
2023-08-06 12:57:43 +02:00
Jean-Christophe
8764da1ca9 Merge pull request #6800 from jaschob/issue6005-heap-not-stack
Allocate on Heap, Not Stack, in `gaussVertical` and Friends
2023-08-06 12:46:13 +02:00
Beep6581
f4dab3c46c Merge pull request #6796 from Benitoite/patch-23
macOS: fixes -cli
2023-08-06 12:45:25 +02:00
Beep6581
e1a6e74ab8 Merge branch 'dev' into patch-23 2023-08-06 12:45:18 +02:00
Beep6581
ea5cfc8814 Merge pull request #6812 from Benitoite/patch-26
Mac bundle: handle harfbuzz update
2023-08-06 12:44:38 +02:00
Beep6581
1b3d80ccc8 Merge pull request #6775 from Christian-Kr/dev
Add .idea to .gitignore.
2023-08-06 12:44:13 +02:00
Lawrence Lee
c82369843e Show icon in external editor button when disabled 2023-08-05 10:11:54 -07:00
Lawrence Lee
7ad414aa63 Fix macOS external editor app chooser popping up 2023-08-04 22:32:39 -07:00
Hombre57
4f752154cf Moving FileBrowserEntry static variable initialization to a dedicated
method. Fixes a crash introduced by PR #5435.
2023-08-03 20:12:52 +02:00
Benitoite
961c2d09d5 Mac bundle: handle harfbuzz update
Harfbuzz was recently upgraded and it broke the default link to graphite.
2023-08-02 16:05:45 -07:00
Jean-Christophe
e3e73e6a83 Merge pull request #5435 from Beep6581/std-mutex
Converting Glib's mutex (obsolete) to std::mutex
2023-08-02 21:10:28 +02:00
Jean-Christophe
0c04fe9ca7 Merge pull request #6715 from RubisetCie/patch-1
Fixed typo "lominosité" -> "luminosité"
2023-08-02 21:06:53 +02:00
Lawrence Lee
a626bdae3e Fix external editor on macOS
Avoid using Gio::AppInfo.
2023-07-31 22:57:57 -07:00
Michael Jaschob
31bbe91760 Use std::vector Instead of Manually Managed Memory 2023-07-27 14:31:53 -06:00
Benitoite
655447b0f1 macos: gitignore .DS_Store files
A .DS_Store file is automatically generated by the macOS Finder that contains the parent folder's metadata (a database of icon positions and background image selections). Adding this to the .gitignore so we don't have to manually remove them when committing to the repository.
2023-07-26 17:19:35 +07:00
Michael Jaschob
5b2811f42b Allocate on Heap, Not Stack, in gaussVertical and Friends 2023-07-22 22:20:29 -06:00
Benitoite
1fb5a5b735 macOS: fixes -cli
Fixes the Command Line Interface (CLI) rawtherapee-cli executable for macOS using ad hoc codesign.
2023-07-16 20:53:37 -07:00
Lawrence37
b68a6e9581 Merge pull request #6790 from luzpaz/typos
Fix various typos
2023-07-12 21:22:54 -07:00
Lawrence37
e67a402320 Merge pull request #6785 from Lawrence37/eos-r5-white-level
Canon EOS R5 white level
2023-07-12 21:20:45 -07:00
Lawrence37
b08a571d7c Merge pull request #6777 from Christian-Kr/bug-#6329
Bug #6329: Variable done should be set to true inside loop, otherwise one fail w…
2023-07-12 21:18:55 -07:00
Lawrence37
2b5ca1b78a Merge pull request #6776 from Christian-Kr/bug-#5912
Bug #5912: Set dummy width and height for ThumbBrowserEntry, cause height will b…
2023-07-12 21:17:51 -07:00
luzpaz
b0ebab8e08 Fix various typos
Found via `codespell -q 3 -S ./rtdata/languages -L activ,alph,ba,bloc,bord,chang,childs,currentry,dof,dum,fo,hist,inout,invers,lonly,makro,ois,pres,preserv,portugues,rady,reall,redy,struc,tbe,thre,trough,vart,vekto`
2023-07-05 13:51:11 +00:00
Hombre57
d912dd1e51 Ending conversion to std::thread and std::mutex 2023-07-04 00:30:25 +02:00
Lawrence Lee
fcf22ea33a Update white level for Canon EOS R5
Drop the white level slightly to account for noise. White level
confirmed in https://github.com/Beep6581/RawTherapee/issues/6783.
2023-07-01 18:39:05 -07:00
Hombre57
80a2d199db Merge remote-tracking branch 'origin/dev' into std-mutex 2023-07-02 00:38:16 +02:00
Lawrence37
1d9225dfc3 Merge pull request #6774 from Lawrence37/hsv-equalizer-pipette-crash
Fix for HSV equalizer pipette crash
2023-06-30 22:24:43 -07:00
Lawrence37
9ca2217603 Merge pull request #6766 from Lawrence37/lab-curve-histogram-scale-fix
Fix for L*a*b* curves histogram scaling and pipette values
2023-06-30 22:24:27 -07:00
Lawrence37
f490e9c607 Merge pull request #6765 from Lawrence37/pipette-lab-fix
Fix L*a*b* values in the lockable color picker and navigator
2023-06-30 22:24:07 -07:00
Christian-Kr
a1356df06a Merge branch 'Beep6581:dev' into dev 2023-06-26 21:21:46 +02:00
Jean-Christophe
4c10df47e7 Merge pull request #6781 from Beep6581/curve-height-fix
Fix for curves widget partially hidden
2023-06-26 13:00:54 +02:00
Hombre
b950477bc9 Fix cropped curves widget 2023-06-25 17:42:34 -07:00
Christian-Kr
d0de0a362e Merge branch 'Beep6581:dev' into dev 2023-06-25 08:41:27 +02:00
Christian-Kr
81b6dd8be4 Refactor code to be more readable. 2023-06-25 08:23:33 +02:00
Desmis
0404a47fb7 LA Color and Light - Merge file - Screen : improve behavior (#6779)
* Change merge secreen in LA color and light

* Remove warning in console
2023-06-25 08:02:53 +02:00
Christian-Kr
0507b0a26a Add a comment why setting the position of a not drawn thumb is needed here. 2023-06-25 06:50:13 +02:00
Lawrence37
c6028d0364 Merge pull request #6768 from Lawrence37/eos-r8-raw-crop
Camconst entry for Canon EOS R8
2023-06-24 16:26:28 -07:00
Lawrence37
634b34b726 Merge pull request #6767 from Lawrence37/windows-dependencies-ldd
Automatically detect DLLs for Windows packages
2023-06-24 16:23:13 -07:00
Christian-Kr
960d1fef1f Variable done should be set to true inside loop, otherwise one fail will cause to stay in loop forever. 2023-06-19 19:52:25 +02:00
Christian-Kr
a4eeb66145 Set dummy width and height for ThumbBrowserEntry, cause height will be used to calculate the height of the scroll pane. Positions also need to be set as a dummy, cause no method allows only width or height. 2023-06-19 19:05:42 +02:00
Christian-Kr
8e64057e23 Add .idea to .gitignore. 2023-06-18 12:54:45 +02:00
Lawrence Lee
1ea0ef8af1 Fix HSV equalizer pipette crash
Check if pipette buffer is valid before filling it in the RGB process.
2023-06-17 22:07:46 -07:00
Lawrence37
b0714e7c00 Merge pull request #6691 from elliptic-shiho/fix-jpeg-exif-buffer-size
Fix the buffer-size computation flow of exif marker of JPEG
2023-06-13 20:53:51 -07:00
Lawrence37
0a3a314d82 Merge pull request #6687 from matei-georged/georgem_6630_fix_pdaf_crash_nikonz50
PDAF lines filter crashes with RAWs from Nikon Z 50
2023-06-13 20:50:59 -07:00
Lawrence37
4517bf521d Merge pull request #6742 from hfiguiere/rtexif-leak
Issue #6735 - Remove memory leak when processing Fuji RAF converted to DNG
2023-06-13 20:50:01 -07:00
Lawrence37
ae188f6338 Merge pull request #6709 from hfiguiere/dcraw-6708
Issue #6708 - fix overlapping buffer strcpy
2023-06-13 20:49:27 -07:00
Lawrence37
bca2d05f95 Merge pull request #6645 from Entropy512/user_icc
iccstore: Allow loading profiles from user-writable configuration directory
2023-06-13 20:48:56 -07:00
Lawrence37
045d2fa37c Merge pull request #6711 from Benitoite/patch-21
Mac: add CR3 defalut handling
2023-06-13 20:48:28 -07:00
Lawrence37
c07a6e8901 Merge pull request #6641 from Lawrence37/tone-equalizer
Global tone equalizer
2023-06-09 21:15:58 -07:00