47 Commits

Author SHA1 Message Date
Ingo Weyrich
9a4ade6f20 devirtualize method calls by declaring classes and methods final 2020-01-23 22:18:46 +01:00
Ingo Weyrich
ffa461d3de Bottleneck when loading Panasonic RW2 files, #5517 2019-11-07 18:47:11 +01:00
Ingo Weyrich
cac2eb53ef Further reduction of include dependencies 2019-10-31 20:41:08 +01:00
Flössie
add5c790d6 #pragma once for our headers plus drive-by formatting 2019-10-31 10:20:50 +01:00
Ingo Weyrich
068847eb5a Further cleanup of include dependencies 2019-10-29 21:06:27 +01:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
Ingo Weyrich
96bf78fe87 Merge branch 'dev' into cppcheck 2019-08-05 16:34:48 +02:00
Ingo Weyrich
46cbb652d5 cppcheck: further fixes 2019-08-01 14:02:38 +02:00
Ingo Weyrich
4101102ddf cppcheck: further fixes 2019-07-31 20:02:35 +02:00
Ingo Weyrich
17f343f682 add -Wcast-qual switch and fix all related warnings 2019-07-25 17:45:43 +02:00
Flössie
9fe6bcaab1 Merge branch 'dev' into relax-procparam-dependency 2019-03-10 12:54:04 +01:00
Flössie
70475f781a Derive lens name from 0xA434 and 0xA433 if other means fail (#5157)
Implemented for
- Pentax
- Canon
- "Unknown"

Also constified `toString()` methods in `rtexif`.
2019-03-07 19:29:11 +01:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
Flössie
e39726dbf7 Return first frame in FramesData on OOB access (#4830) 2019-02-20 20:55:07 +01:00
Flössie
c85dc2811b Fix most Clang 7 warnings (fixes #4972) 2019-02-17 12:07:48 +01:00
heckflosse
944b901a65 Fix some coverity issues, next try... 2018-11-22 22:07:39 +01:00
heckflosse
831e18ca45 Add override keyword. Thanks @Floessie 2018-11-22 16:19:16 +01:00
heckflosse
7f32010895 Fix coverity issues 2018-11-21 16:21:05 +01:00
Hombre
ec2181f7ff Fix #4532, Fix #4533 : Pentax HDR/PEF and 16/24 bits float support 2018-05-06 17:14:44 +02:00
Hombre
466aa17295 Fixing linking error : removed 'inline' statement (see #4393) 2018-03-02 22:08:08 +01:00
luz.paz
c3c3ceac79 Misc. typos
Found via `codespell` 
+ removed rtengine/dcraw.patch per discussion in https://github.com/Beep6581/RawTherapee/pull/4395
2018-02-14 14:07:18 -05:00
Hombre
2f1ab34ef1 Attempt to fix clang warnings in rtexif/stdattribs.cc (see #2017)
https://github.com/Beep6581/RawTherapee/issues/2017#issuecomment-361060194
2018-01-28 14:47:56 +01:00
Hombre
ee2c8f01e0 Merge branch 'dev' into tiff32float 2018-01-01 15:24:00 +01:00
Hombre
9d2ccc19d3 Better UNICODE support (UCS-2/UTF-8) for Exif.UserComment (#2017)
- BOM is now checked and correctly handled
- auto-detection of UTF-8 string if no BOM available, otherwise assume
it's an UCS-2/UTF-16 string
- try to autodetect endianess of UTF-16 string by counting zeros
- possibility to enable writing BOM for this field (disabled for now)
- for undefined charset (empty identifier), RT now assume that the
string is what glib think is the local charset (not tested), and try to
convert it to UTF-8 for display/editing

JIS is still not handled though.
2018-01-01 14:24:47 +01:00
Flössie
0b7b1d6ab3 Fix null pointer dereference (as hinted by Coverity)
Plus some `const` fixes.
2018-01-01 12:13:29 +01:00
Alberto Griggio
7dea8a3ea8 added support for writing metadata in PNG files
Fixes #3352
2017-12-28 22:26:22 +01:00
Hombre57
2ef064f7d4 Various bugfix (see #4008) :
1. RT could crash in some circumstances with single frame image
2. UNICODE UserComment now done when already existing in raw file
3. When editing UserComment in the ExifPanel, the Value filed is now
filled with the current value
2017-10-07 00:43:45 +02:00
Hombre57
bb874bcce7 Bigfix (see #4008) :
- CIECam now gets the shot's setting of the selected frame
- 'UserComment' metadata now correctly handled
- RT prepared to handle XTrans multiframe
- SensorType now set in the cache/data files
2017-10-04 23:27:08 +02:00
Hombre57
17c7ec684d PixelShift detection for PEF files was broken (see #4008) 2017-09-17 23:05:34 +02:00
Hombre57
ee0bff4124 Updated frame handling with any type of hierarchy (see #4008)
Images can now be detected in nested IFDs or as root IFDs.
2017-09-16 22:30:07 +02:00
Hombre57
d5e4980c08 Adding Floessie's patch to use std::unique_ptr (issue #4008) 2017-08-12 19:21:29 +02:00
Hombre57
1a296b763f Correction as discussed in commit review (see also issue #4008) 2017-08-10 00:50:26 +02:00
Hombre57
f23be9345c Add multi-frame handling.
- Exif of all frames are displayed in the Editor's Exif tab (without
separator)
- isHDR and isPixelShift is added to the data files stored in cache
- In the Editor panel, the QuickInfo frame display the HDR and
PixelShift information, as well as the number of frame and bit-depth for
HDR image
- the number of frame is provided by dcraw. If not set, it is provided
by the Exif's main IFD count
- the PixelShift information (for Pentax as of now) is provided by
looking at the Exif informations
- the HDR information is provided by the Exif information of the first
frame for Pentax raw files, or by the bitspersample, sampleformat and
compression tags for other files

TODO: add icons to the thumbnails to tag HDR and PixelShift files.
2017-08-08 23:42:05 +02:00
Morgan Hardwood
22875bed9d Merge branch 'dev' of https://github.com/t0pu/RawTherapee into t0pu-dev 2017-04-18 21:49:48 +02:00
topu
f2b0efecce Show lens used on Panasonic cameras 2017-04-17 17:12:06 +02:00
Morgan Hardwood
33a940cef4 astyled rtexif files, #3802 2017-04-15 21:36:53 +02:00
Flössie
0731975ff0 Apply modernize-use-nullptr
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
Flössie
d132149a26 Introduce rtengine/noncopyable.hpp 2016-10-08 15:36:44 +02:00
heckflosse
260cd290fb Cppcheck: Fix most issues in rtexif/* 2016-10-03 21:01:26 +02:00
heckflosse
ccd9002c3a Cppcheck: Solve issues related to copy constructor 2016-10-02 23:33:00 +02:00
heckflosse
c8779c04f5 Fix all - 2 cppcheck performance hints 2016-07-06 13:04:24 +02:00
heckflosse
87e1914b9d Fix buffer overrun writing uncompressed tiff 2016-07-03 16:06:07 +02:00
heckflosse
5cd202ddb5 Fix build on Arch 32bit non SSE using gcc-6.6.1, fixes #3305, kudos to mbajor for reporting and to Floessie for providing a fix for the bug 2016-05-24 23:46:43 +02:00
Adam Reichold
85c809ce6c Also remove the SafeKeyFile wrapper class. 2016-02-21 10:26:11 +01:00
Adam Reichold
e52ce5c485 Replace a dubious manual return-value-optimization by a standard named-return-value-optimization to simplify leak detection. 2015-11-28 14:31:46 +01:00
DrSlony
0e0cfb9b25 Formatted all .cc and .h code in rtengine, rtexif and rtgui using astyle 2015-08-11 11:55:03 +02:00
torger
d5ca351c20 Issue 2134: removed obsolete raw highlight preservation setting from GUI (still left in procparams for backwards compatilibility) 2015-07-10 12:00:36 +02:00