Commit Graph

10710 Commits

Author SHA1 Message Date
Lawrence Lee
edbf701264 Improve style of scope buttons
Keep all buttons at the same place and use darkened button background
instead of tiny icons to indicate which scope type is active.
2020-10-03 22:37:13 -07:00
Lawrence Lee
04524b6332 Change vectorscope crosshair style
The original crosshair used dashed lines extending across the
vectorscope area. The new crosshair uses solid lines with a small
length.
2020-10-02 22:19:33 -07:00
Lawrence Lee
6b667ead58 Swap positions of scope buttons
Make the scope type buttons the primary buttons and the other options
secondary.
2020-10-02 22:14:29 -07:00
Lawrence Lee
b8af429f0e Prevent null pointer access
Thanks to Ingo for fixing the segfault.
2020-09-28 22:17:49 -07:00
Lawrence Lee
be858363a6 Merge from upstream branch 'waveform' 2020-09-26 16:34:07 -07:00
Lawrence Lee
cecb753595 Increase performance of some scopes 2020-09-26 16:30:51 -07:00
Lawrence Lee
0ad5f9587f Fix segfault
Make sure histogramRGBArea isn't null before using it.
2020-09-26 12:40:14 -07:00
Lawrence Lee
1a5456dbd1 Implement RGB parade 2020-09-26 11:54:05 -07:00
Ingo Weyrich
8d2754575a remove call to fomerly removed function 2020-09-23 18:17:15 +02:00
Lawrence Lee
6e7185081a Fix scaling of H-C vectorscope 2020-09-22 22:10:57 -07:00
Lawrence Lee
79e79321ec Remove spacing around vectorscope lines 2020-09-22 21:35:08 -07:00
Lawrence Lee
98ae27f60e Fix initialization of vectorscope pointer 2020-09-22 21:32:49 -07:00
Flössie
97c7794a5a Turn Options::ScopeType into a scoped enum :)
Also remove global `using ...` from header file.
2020-09-14 09:44:29 +02:00
Lawrence Lee
af29bf84e6 Fix cppcheck warnings for uninitialized variables 2020-09-13 12:33:25 -07:00
Lawrence Lee
c03efe4878 Add dedicated buttons for scope switching
Previously, changing to a different scope was done by clicking the scope
type button and cycling through all scopes. This commit decreases the
number of clicks needed to switch between two scopes by adding a radio
selector. The radio buttons can be shown or hidden by pressing the scope
type button. This commit also makes the raw histogram one of the scope
types.
2020-09-12 17:52:24 -07:00
Lawrence Lee
bb0c625960 Use enum for scope types 2020-09-07 16:37:40 -07:00
Lawrence Lee
b2942fd949 Improve performance of scopes
If a scope update is requested, don't recalculate scope data if it is
already up-to-date.

Eliminate double and triple scope rendering.
2020-08-28 22:33:52 -07:00
Lawrence Lee
6d8a31961f Color the vectorscope lines 2020-08-27 16:35:39 -07:00
Ingo Weyrich
6c2463889b Revert "CH vectorscope: speedup by avoiding conversions"
This reverts commit cfc1e66024.
2020-08-20 12:31:37 +02:00
Ingo Weyrich
cfc1e66024 CH vectorscope: speedup by avoiding conversions 2020-08-19 14:00:09 +02:00
Lawrence Lee
350324affc Disable double-clicking of waveform & vectorscopes 2020-08-16 18:08:26 -07:00
Lawrence Lee
371fc65416 Improve type conversions 2020-08-16 16:10:46 -07:00
Ingo Weyrich
e667e3dce7 Removed timing code and some includes 2020-08-16 21:34:11 +02:00
Ingo Weyrich
2858876f44 use array2D.fill() instead of memset() 2020-08-16 17:19:59 +02:00
Flössie
7aa6b713c6 Fix vectorscope 2020-08-16 16:01:29 +02:00
Ingo Weyrich
d59f488aea minor fixes 2020-08-16 14:07:25 +02:00
Ingo Weyrich
9e040b3bc2 ImProcCoordinator::updateVectorscope(): parallelize loops 2020-08-16 11:46:17 +02:00
Flössie
3af822b6f7 Fix abuse of array2D<>
- Add copy c'tor and assignment to `array2D<>`
- Use `std::vector<>` instead of smart pointer to array
- Constify a bit
- Make use of `rtengine::max(...)`
2020-08-16 11:22:10 +02:00
Flössie
231c5e2c99 Apply clang-tidy's google-readability-casting
```
clang-tidy-10 -header-filter=.* -p=build -fix -checks=google-readability-casting rtgui/histogrampanel.cc
```
2020-08-16 10:25:22 +02:00
Flössie
c5ace05df8 Merge branch 'dev' into waveform 2020-08-16 10:08:28 +02:00
Floessie
4888cb76f2 Merge pull request #5878 from Beep6581/delayed_connection
Delayed GUI updates
2020-08-16 09:32:53 +02:00
Ingo Weyrich
e67b02da8b further cleanups 2020-08-15 22:36:10 +02:00
Ingo Weyrich
07d26c16ed ImProcCoordinator::updateVectorscope(): fix crash caused by large stack allocation, speedup, fixed scaling from [0;255] to [0;65535] range 2020-08-15 17:35:24 +02:00
Ingo Weyrich
1aa3b5c52b dcraw.cc: fix some warnings 2020-08-14 13:37:59 +02:00
Ingo Weyrich
a4813ac256 RT build on non-Apple systems using clang shows wrong compiler info in AboutThisBuild.txt, fixes #5864 2020-08-14 12:22:08 +02:00
Ingo Weyrich
20f13048d4 Merge pull request #5884 from Beep6581/cleanups_202008
Cleanup: removed unused function; also murder instead of call for sui…
2020-08-13 15:18:09 +02:00
Ingo Weyrich
e19321982c Further cleanup 2020-08-13 13:27:01 +02:00
Ingo Weyrich
1419a01940 Further cleanup 2020-08-13 13:26:27 +02:00
Ingo Weyrich
a5c7713042 Cleanup: removed unused function; also murder instead of call for suicide (delete this) 2020-08-13 13:10:33 +02:00
Flössie
e4d037c7a9 Merge branch 'dev' into delayed_connection 2020-08-10 14:00:37 +02:00
Flössie
a55e06c676 Remove C++14isms from delayed_helper::apply()
Clang to the rescue:
- `void` isn't a literal type in C++11
- calling `f()` from `constexpr` isn't allowed in C++11

So, remove `constexpr` to simplify things.
2020-08-10 13:55:45 +02:00
Desmis
130fbb8eb2 Local complexity - Add 'Basic' to 'Standard'(Normal) and 'Advanced'(Expert) (#5858)
* Mode simple to color and light

* Exposure complex

* Vibrance and SH complex

* Soft and Blur complex

* Common mask complex

* Sharp Retinex complex

* Localcontrast complex

* Change label tooltip complex

* Change labels and tooltip

* Change tooltip french

* Change default value scope TM

* Some forgotten hide..with basic in inverse mode

* Another hide in basic and inverse

* Change some type in labels

* Change typo contrast

* Refine some labels tootips

* Change after review Ingo - thanks

* Improve history behaviour when changing local adjustments complexity mode

* Added normal to original retinex - basic to dehaze

* Fixed bad behavior normal expert Color and Light

* Improve edge sharpness

* Another improvment edge sharpness

* various improvement

* locallab: speedup and reduced memory usage for wavcontrast4()

* remove file

* French labels complexity

* calckoe(): cleanup, speedup and bugfix for 3x3 gaussian kernels

* calckoe(): cleanup for 3x3 gaussian kernels

* calckoe(): fill koeli[] with zeroes if level <= 1 && tloww >= 75.f

* GUI part fixes and cleanup

* Fix in Locallab Settings panel

Additionnal minor fix in Preferences windows

* Change default mode complexity in preferences - basic

* Change complexity in option

* Improve gui when lauch first image

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Pandagrapher <pierre.cab@gmail.com>
2020-08-10 13:18:21 +02:00
Lawrence Lee
e247a1e086 Increase visibility of vectorscope pointer 2020-08-09 18:00:12 -07:00
Lawrence Lee
f7c02af184 Fix rendering of blank vectorscope 2020-08-09 17:22:23 -07:00
Lawrence Lee
8b3af4c520 Fix some cppcheck warnings 2020-08-09 17:16:57 -07:00
Lawrence Lee
6cd87ad975 Use array2D for waveform and vectorscopes 2020-08-09 16:49:28 -07:00
Lawrence Lee
2f06f56d9c Merge from dev 2020-08-08 22:02:29 -07:00
Lawrence Lee
ec27ad4abc Add waveform/vectorscope brightness feature 2020-08-08 17:11:18 -07:00
Lawrence Lee
6c53317ac1 Add pointer indicator for vectorscopes 2020-08-08 13:00:18 -07:00
Lawrence Lee
f779527833 Clip H-C vectorscope according to color profile 2020-08-08 12:37:28 -07:00