3754 Commits

Author SHA1 Message Date
Desmis
efbcebb522
Review JzCzHz - Various changes to locallabtools2 - default - french (#6561)
* Various changes to locallabtools2 default french

* changed to German TP_LOCALLAB_LOGAUTOGRAYJZ_TOOLTIP
2022-08-25 14:01:17 +02:00
Lawrence37
0a55428205
Clean up missing language keys (#6556)
* Clean up some unused code

* Use grid for abstract profile primaries

* Remove blank line from default
2022-08-24 20:23:09 +02:00
Thanatomanic
c58f582505
Minor license path fixes (#6551)
* Fix CMakeLists
* Fix splash.cc
2022-08-18 20:58:50 +02:00
Ingo Weyrich
f564394bbc
dfmanager cleanup (#6211)
* Turn `DFManager` into a singleton
* PIMPL `DFManager`
* Cleanup namespace usage in `dfmanager.cc`
* Constify `DFManager` interface
* Fix bad `reinterpret_cast` between `std::string` and `Glib::ustring`

Co-authored-by: Flössie <floessie.mail@gmail.com>
Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
2022-08-18 17:00:49 +02:00
luzpaz
65db39b9f8
Fix various typos (#6529) 2022-08-18 16:49:26 +02:00
Lawrence Lee
262d00bf1b Fix incomplete changing of input profile
Closes #6533.
2022-07-23 15:59:40 -07:00
Pandagrapher
1e2dc30738
Local adjustments - Fix apply/paste actions with LA
- Fixes LA lost when applying partial profile (fixes #6150)
- Fixes LA behavior when using apply/paste actions: spots are now totally replaced and not anymore merged (fixes #6136 and #6411)
- Fixes a crash in specific situations when saving/copying a partial number of spots
- Partial paste dialog: Fixes Locallab button remaining inconsistent if all the spots are deselected
2022-07-18 19:03:29 +02:00
Desmis
19a4720ec7 Fixed bad GUI behavior in Color and Light - issue 6517 2022-07-06 11:01:14 +02:00
Desmis
01570e3430 Fixed bad GUI behavior gamma in DR Exposure issue 6507 2022-06-23 14:10:12 +02:00
Lawrence Lee
2df26028b8
Fix auto perspective correction not working
Use default focal length and/or crop factor if undefined.

Closes #6487.
2022-05-21 15:11:00 -07:00
Lawrence37
37080e1b5d
Fix some history messages (#6474)
Use correct key for spot removal history message.

Remove B&W channel mixer auto enabled message when changing the filter
color.

Replace hard-coded input color profile strings.
2022-05-14 05:39:31 +02:00
Desmis
c45a6105f7
Improvments to LA Sigmoid - LA Log encoding Cam16 and ICC profile creator (#6410)
* Improvment to sigmoid Cam16 and Jz
* Change default parameters contrast sigmoid
* Log encoding Q added to Sigmoid Q - Cam16
* Change DR evaluation for sigmoid
* Change default log encoding cam16 and change tool position options
* DCI-P3 added to Iccprofilecreator
2022-03-26 12:04:21 +01:00
Jonathan Bieler
d80b3c71d1
Add default spot size control (#6371)
* added adjuster to change default spot size in spot removal tool

* added translation for default spot size

* removed unnecessary adjuster methods
2022-03-26 11:44:09 +01:00
Bezierr
c2c7f2c862
Film Simulation ComboBox for long HaldCLUT names (#6423)
* Film Simulation ComboBox for long HaldCLUT names

Small change that makes the Film Simulation ComboBox look better if there are HaldCLUT names that are too long to fit into it

* Ellipsize long HaldCLUT names

Functionality moved to ClutComboBox constructor.

* Wrapped in Gtk::manage

Wrapped in Gtk::manage

* Compacted.
2022-03-26 11:34:42 +01:00
Lawrence Lee
9c5ce0d9bb Fix focal len autofill after browser adjustments
Don't update the camera-based perspective focal length and crop factor
parameters when making other adjustments using the file browser or batch
editor.

Closes #6402
2022-01-08 12:02:25 -08:00
Desmis
690fab3d08 Changes a brace in iplocalla and 2 warning in locallabtools2 - thanks to Floessie 2021-12-21 11:21:25 +01:00
Desmis
1e4f41bc05
LA - new tool - Color appearance (Cam16 & JzCzHz) (#6377)
* Gui improvments

* Several improvments GUI Jz algo

* Change function La for lightess Jz

* SH jzazbz first

* enable Jz SH

* Clean code

* Disabled Munsell correction when Jz

* Change tooltip and Cam16 Munsell

* GUI for CzHz and HzHz curves

* Enable curves Hz(Hz) Cz(Hz)

* Improve Cz chroma

* Jz100 reference refine

* Change limit Jz100

* Refine link between jz100 and peak adaptation

* Improve GUI

* Various improvment PQ PU gamut

* Change defaults settings

* forgotten PL in gamutjz

* Small changes and comment

* Change gamujz parameter

* disabled gamut Jz too slow

* Jzazbz curve Jz(Hz)

* reenable gamutjz

* small changes

* Change tooltip

* Change labels tooltips

* Jzazbz only on advanced mode

* GUI improvments

* Change tooltip

* Change default values and tooltip

* Added tooltip Jz

* Disabled Jz gamut

* Change gamma color and light - remove exposure

* Gamma for exposure and DR

* gamma Sharp

* Gamma vibrance

* gamma optimizations

* Change tooltips

* Optimization PQ

* LA GUI for tone curve Ciecam

* LA ciecam Enable curve lightness - brightness

* LA ciecam GUI color curve

* LA ciecam enable color curve

* Change tooltip and default values

* Enable Jz curve

* Enable Cz(Cz) curve

* Enable Cz(Jz) curve

* Added Log encoding to ciecam

* Improvment algorithm remapping

* Reenable forgotten listener logencodchanged

* Change Jz tooltips

* Reenable dynamic range and exposure

* First change GUI auto ciecam

* 2nd fixed ciecam auto

* Improve GUI maskbackground curves

* Enable activspot for la ciecam

* set sensitive sliders La ciecam when auto scene conditions

* Change internal calculations see comments

* Checcbox ForceJz to 1

* Change tool position - change order CAM model

* Expander for Jzczhz

* Remove unused code

* GUI changes

* Change labels CAM16 Jzazbz

* Change slider brightness parameters

* improvment SH jz

* Some changes to brightness Jz

* Fixed scene conditions auto

* Renable forgotten change

* Prepare calculation Zcam

* Prepare Iz for zcam

* First GUI Zcam

* Improve GUI Zcam

* Calculate Qz white - brightness of the reference white

* Prepare for PQ - eventually

* Init LUT ZCAMBrightCurveJz and ZCAMBrightCurveQz

* prepare zcam achromatic variables

* First zcam

* Change algo step 5 zcam

* Another change original algo

* Another change to original algo

* first colorfullness

* Fixed bad behavior threshold and change c c2 surround parameters

* added saturation Zcam

* Change parameters surround

* Enable chroma zcam

* change chroma and lightness formula

* disable OMP for 2nd process Zcam

* Improvment zcam for some high-light images

* Change parameters overflow zcam

* Change parmeters high datas

* another change to retrieve...

* Simplify code matrix conversion xyz-jzazbz

* Adjust internam parameters zcam

* Change some parameters - clean code

* Enable PQCam16

* Enable PQ Cam16 - disable ZCAM

* remove warning compilation message

* Change GUI jzczhz

* Fixed bad behavior remaping jz

* Remove forgotten parameter - hide Jz100 - PU adaptation- chnage tooltips

* Another change to chroma parameter

* Small changes

* If verbose display in console Cam16 informations

* If verbose display in console source saturation colorfullness

* Change to La calculation for ciecam

* Change GUI cam16 - jzczhz - remove cam16 and jzczhz

* Disable exposure compensation to calculate La for all Ciecam and Log encoding

* Change label Cam16 and jzczhz

* Improve GUI Jz

* Other improvment GUI Jz Cam16

* verify nan Jz and ciecam matrix to avoid crash

* Enable La manual for Jz to change PU-adaptation

* Improve calculation to avoid crash Jz and Cam16 matrix

* Fixed crash with local contrast in cam16

* Clean code loccont

* First step GUI Cie mask

* GUI part 2 - Cie

* Build cieMask

* Gui part 3 cie

* Valid llcieMask

* Valid llcieMask

* Pass GUI curves parameters to iplocallab.cc

* 2nd pass parameters from GUI to iplocallab.cc

* Init first functions modifications

* Add expander to cam16 adjustments

* First test mask cie

* Various improvment GUI - tooltips - process

* Take into account Yb cam16 for Jz - reenable warm-cool

* Surround source Cam16 before Jz

* Improve GUI and process

* Fixed bug and bad behavior last commit

* Fixed bug chroma mask - improve GUI - Relative luminance for Jz

* Increase sensitivity mask chroma

* Improve Jz with saturation Z - improve GUI Jzczhz

* Small code improvment

* Another change mask C and enable mask for Cam16 and Jz

* Some changes

* Enable denoise chroma mask

* Small change LIM01 normchromar

* Enable Zcam matrix

* Improve chroma curves...mask and boudaries

* take into account recursive slider in settings

* Change tooltip - improvment to C curve (denoise C - best value in curves - etc.) - remove Zcam button

* Change tooltips

* First part GUI - local contrast wavelet Jz

* Passed parameters GUI local contrast wav jz to rtengine

* save config wavelet jz

* first try wavelet local contrast Jz

* Add tooltips

* Simplify code wavelet local contrast

* take into account edge wavelet performance in Wavelet Jz

* Fixed overflow jz when usig botth contradt and wavelt local jz contrast

* Adapt size winGdiHandles in filepanel to avoid crash in Windows multieditor

* First GUI part Clarity wavelet Jz

* First try wavelet Jz Cz clarity

* Added tooltips

* Small change to enable wavelet jz

* Disabled (commented) all Zcam code

* Improve behavior when SH local-contrast and Clarity are use both

* Change limit PQremap jz

* Clean and optimize code

* Reenable mjjz

* Change settings guidedfilter wavelet Jz

* Fixed crash when revory based on lum mask negative

* Change tooltip

* Fixed ad behavior auto mean and absolute luminance

* Remove warning in console

* Fixed bad behavior auto Log encoding - bad behavior curves L(H) Jz

* Fixed another bad behavior - reenable curves color and light L(H) C(H)

* first transposition Lab Jz for curves H

* Change mask boundary for Jz

* Various improvment to H curves Jz

* Add amountchrom to Hcurve Color and Light

* Improve gray boundary curves behavior

* reenable Jz curve H(H) - soft radius

* Improve guidefilter Jz H curve

* Threshold chroma Jz(Hz)

* Enable guidedfilter chroma curve H

* improve GUI curves Hz

* Checkbutton chroma for curve Jz(Hz)

* Change event selectspot

* Clean and small optimization code

* Another clean code

* Change calculation Hz references for curves Hz

* Clean code

* Various changes to GF and GUI

* Another change to Chroma for Jz(H)

* Change GUI sensitive Jz100 adapdjzcie

* Improve code for Jz100

* Change default value skin-protection to 0 instead of 50

* Clean code

* Remove BENCHFUN for ciecam

* small correction to huejz_to_huehsv2 conversion

* Added missing plum parameter for jch2xyz_ciecam02float

* another small change to huejz_to_huehsv2

* Improvment to huelab_to_huehsv2 and some double functions

* Fixed warning hide parameters in lgtm-com

* Fixed ? Missing retuen statement in lgtm-com

* Change behavior Log encoding whith PQ Cam16

* Small improvment to Jz PU adaptation

* Added forgoten to_one for Cz slider

* Replace 0.707... by RT_SQRT1_2 - change some settings chroma

* Improvment to getAutoLogloc

* Fixed crash with array in getAutoLogloc

* First try Jz Log encoding

* Forgotten Cz

* Various improvment GUI setlogscale - Jz log encoding

* Change labels tooltips Jz log

* Change wrong clipcz value

* Change tooltip auto scene conditions

* Fixed bad behavior blackevjz whiteevjz

* Small improvment to LA Log encoding std

* Avoid bad behavior Jz log when enable Relative luminance

* Change sourcegray jz calculation

* Revert last change

* Clean and comment code

* Review tooltips thanks to Wayne - harmonize response La log encoding and Jz Log encoding

* Always force Dynamic Range evaluation in full frame mode for Jz log encoding

* Remove unused code

* Small optimizations sigmoid Cam16 and Jz

* Comment code

* Change parameters deltaE for HDR

* Various improvment to Jz - La - sigmoid - log encoding

* Basic support for Sony ILCE-7M4 in camconst.json

* German translation Spot Removal (#6388)

* Filmnegative German translation (#6389)

* (Temporarily) disable `ftree-loop-vectorize` for GCC 11 because of #6384

* Added BlacEv WhiteEv to sigmoidJz

* Improve GUI for BlackEv WhiteEv

* Change location SigmoidJz in Iplocallab

* Improvment GUI and sensitivity sliders strength sigmoid

* Change labels

Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
Co-authored-by: Anna <simonanna@gmx.net>
2021-12-21 07:43:59 +01:00
Desmis
a1bbede061 Fixed missing entries history msg wavelet issue 6381 2021-11-12 17:24:28 +01:00
Ingo Weyrich
e4ee63850d
Add an average filter for pixel shift to process the moving parts, closes #6376 (#6380) 2021-11-10 17:54:57 +01:00
Ingo Weyrich
d053f02450 Do not explicit enable white balance when switching method, fixes #6365 2021-09-19 12:29:09 +02:00
Lawrence37
5268b94cfd
Merge pull request #6302 from Beep6581/spot-rename
Update spot name in history after rename
2021-09-04 12:00:12 -07:00
Desmis
9b26424c3a Set default to brightness in some cases 2021-09-03 10:34:31 +02:00
Desmis
0991b0a380
Ciecam - re enable - curve brightness (#6350)
* Re enable curve ciecam brighness

* Change default tone curve2 to Brightness
2021-09-03 07:51:31 +02:00
Lawrence Lee
0db17f99dd Fix crash while updating RGB parade and waveform
Closes #6349.
2021-09-02 21:52:59 -07:00
Desmis
ba2985a44c
Enable checkbutton preferences - ciecam artifacts (#6347) 2021-08-29 07:39:01 +02:00
Lawrence Lee
d897116507 Change Locallab tool members from pointers to obj.
Ensures the LocallabTools are destructed when Locallab is.
2021-08-27 22:17:41 -07:00
Ingo Weyrich
8bd9bddfc7
New crop guide: square center, closes #6342 (#6345)
* New crop guide: square center, closes #6342

* Turn `CropParams::guide` into an `enum`

This saves recurring string comparisons.

Co-authored-by: Flössie <floessie.mail@gmail.com>
2021-08-25 15:25:59 +02:00
Desmis
b528d67910 Disabled in advanced mode tonecurves brightness 2021-08-23 10:51:53 +02:00
Lawrence Lee
8cb89688a7 Fix CIECAM scene temperature changing unexpectedly
The temperature was unexpectedly changing to 5003 when changing other
settings such as wavelets.

Closes #6326.
2021-08-22 17:07:52 -07:00
Lawrence Lee
d3b67c1e22 Fix empty dialog messages
Escape ampersands and angle brackets in some Gtk::MessageDialogs.
Closes #6306.
2021-08-15 12:23:29 -07:00
luzpaz
22f89bc752
Fix various typos (#6332)
* Fix various typos

Found via `codespell -q 3 -S ./rtdata/languages -L ba,bord,childs,hist,fo,reall,bloc,alph,dof,inout,thre,makro,chang,currentry,preserv,portugues,struc,trough,vektor`

* Fix source typo

* Added requested revisions
2021-08-13 14:37:29 +02:00
Benitoite
b1e7860a23
mac: update of macosx_bundle.sh (#5786)
Various changes to improve compilation of RT on macOS thanks to @Benitoite and @Pandagrapher 
* mac: use sed -i.bak, add X's to mktemp template in macosx_bundle.sh
* mac: test lensfun version in macosx_bundle.sh to select correct lensfun database version (version_1 for 3.2 and version_2 for 3.95)
* mac: remove DYLD_FALLBACK_LIBRARY_PATH from main Info.plist
* mac: removes some -cli codesigning commands
* mac: remove erroneous newlines in macosx_bundle.sh and suppress superfluous codesigning of Contents/Frameworks/*dylib
* mac: Apple arm64/homebrew compatibility update
* mac: CMakeLists.txt arm64 homebrew compatibility
* mac: add Apple arm64 CPU native flag
* mac: fix pixbuf query syntax
* mac: adapt. of Pandagrapher's patch
* mac: additional instructions for the -cli exec.
* mac: revert target 10
* mac: remove legacy environment variable Per https://github.com/Beep6581/RawTherapee/pull/5786#issuecomment-792276656
* mac: fix destination of credits/license
* mac: copy {LOCAL_PREFIX}/share/locale to bundle
* mac: fixes a path for the License
* mac: fix of UpdateInfo command structure
* mac: remove redundant copying
* mac: use cmake to configure Info.plist values
* mac: configurator for Info.plist version values
* mac: fix locale detection / language
* mac: remove an outdated key from Info.plist
* mac: fix path usage for gtk.immodules / locale dir
* mac: revert a change merged elsewhere
* mac: follow more symlinks for 'brew builds
* mac: link to CoreFoundation for locale detection
* mac: link CoreFoundation for locale / C
* mac: detect locale with CoreFoundation per https://github.com/Beep6581/RawTherapee/pull/5786#issuecomment-798926898
* mac: remove outdated lines
* Update multilangmgr.cc
* mac: Info.plist language fixes (Pandagrapher) https://github.com/Beep6581/RawTherapee/pull/5786#issuecomment-813004475
* Mac: also package libpng12 for homebrew compatibility.
* macOS packaging and language updates
2021-08-09 07:11:09 +02:00
Thanatomanic
6be177d4de
Merge pull request #6317 from Bezierr/ha-profileload-dev
Resize tool values not computed when profile is loaded
2021-08-08 21:00:46 +02:00
rom9
94b5f7232f Ignored ParamsEdited information when doing a partial profile save.
The user-selected params will get saved, overriding any ParamsEdited
filtering.
Fixes #6303
2021-07-27 21:18:08 +02:00
Bezierr
61dcb5113c Merge branch 'ha-profileload-5.8' into ha-profileload-dev 2021-07-27 16:39:33 +02:00
Bezierr
7d02d77fc1 Update resize.cc
Fixes the issue that values in Resize-GUI are not recomputed when loading profile.
E.g. loaded from profile are Specify: width, value for width, value for height => loaded value for height was displayed even if  not corresponding to width for this picture's dimensions.
2021-07-27 14:10:18 +02:00
Lawrence Lee
5a49ea7b8c Get locallab spot name from one source
Fixes #6298.
2021-07-10 09:52:18 -07:00
Flössie
64382928c1 Fix -Wodr in GCC LTO builds
I've tested GCC 10 and 11, which exhibit the problem, and 8, which
doesn't.
2021-07-05 13:06:33 +02:00
Desmis
7d8c876fd3 Abstract profile fixed crash when by=0.5 and all sliders to minimum 2021-07-04 13:17:08 +02:00
Flössie
b6449bfd5f Escape HTML chars in camera/lens name in quick info box (fixes #6294) 2021-06-30 09:18:06 +02:00
Ingo Weyrich
4ab54c9fda Crash when moving crop window using SHIFT+Mouse, fixes #6290 2021-06-24 12:01:18 +02:00
Desmis
3cf3562505 LA small change GUI vibrance 2021-06-23 13:49:53 +02:00
Pandagrapher
491b57bee7
Improves RT window position management, fixes #6233 (#6239)
* Improves RT window events detection and RT window position computation

* Fixes some limitations in specific cases for Windows and MacOS

* Fixes RT window not restoring saved position at startup

- When maximized at startup, RT window position wasn't restored from
options file. So when unmaximazing RT, position was set to up left
corner instead of restored one
- Other fix: Removed some uses of deprecated Gtk functions

* Improves RT window management for independant edit window mode

Other fixes:
- Monitor ID wasn't correctly computed
- Removes some other deprecated functions uses
- Removes debug printf

* Fixes editor window aspects not restored in MEOW mode on Linux

Other fixes:
- Removes some Gtk warnings when adding a new editor panel in MEOW mode
- Adds robustness to avoid RT windows outside screen at startup loading
corrupted options file with negative position values

* Fixes incorrect max position saturation in dual screen configurations
2021-06-21 21:22:14 +02:00
Desmis
a6a8ee0e40 Others fix bad behavior Dynamic range and exposure 2021-06-19 10:36:30 +02:00
Desmis
b35e0d8269 Fixed bad behavior GUI in inverse Dynamic Range 2021-06-18 08:45:29 +02:00
Lawrence Lee
c13cc02768 Un-highlight spot removal spots after deletion 2021-06-12 11:46:54 -07:00
Lawrence Lee
a2c5fd0f91 Fix drag position after alternate button press
When a button is released and the edit state is not "dragging", reset
the drag delta to zero.

There was a problem with the spot removal spots being dragged. If a spot
is deleted while being dragged, dragging another spot will cause a jump.
2021-06-12 11:37:38 -07:00
Flössie
9d052e267d Fix "unused variable" warning on release builds 2021-06-07 15:12:09 +02:00
Bezierr
d86888e93f
Add resizing options "long edge" and "short edge" (#6263)
Introduces "long edge" and "short edge" options to resize an image. The GUI is made such that the relevant spinboxes only appear for the selected option. Unrelated values (e.g. for box-mode) are not updated.
2021-06-05 07:37:09 +02:00
Lawrence37
38ff2b5695
Merge pull request #6268 from Beep6581/perspective-ux
Perspective tool: Improve control lines user experience
2021-06-03 21:37:30 -07:00