466 Commits

Author SHA1 Message Date
Flössie
495c0938f4 Fix Clang warnings and build failure on OSX 10.12
Kudos to Partha over at pixls.us for finding and fixing!
2016-11-06 17:09:27 +01:00
Hombre
2bf87d5c5c Fixing issue #3497: "Lockable color picker interacts with info text on
image area"
2016-11-05 19:13:59 +01:00
Morgan Hardwood
e35e46e0ad Fixes Preferences > Color Management layout, #3488 2016-10-30 20:52:13 +01:00
Morgan Hardwood
2a2dd2af8b Small fix to Preferences > Default Theme frame, no issue. 2016-10-24 21:04:13 +02:00
Hombre
22d8869953 Hotfix for issue #3480. 2016-10-24 01:14:35 +02:00
Morgan Hardwood
0ba6258fc8 Removed 3 Noise Reduction tooltips as they were intrusive and/or incorrect, no issue - IRC 2016-10-20 20:00:09 +02:00
Ingo Weyrich
d14e9adbc2 Merge pull request #3465 from Beep6581/clang-tidy
`clang-tidy` cleanups
2016-10-18 21:53:34 +02:00
Jean-Christophe
952fc5f127 Merge pull request #3461 from Beep6581/connblocker-in-toolbar
Enhanced ConnectionBlocker class, now used in ToolBar class
2016-10-18 21:34:42 +02:00
Flössie
fb8941cd88 Manually simplify bool expressions and fix rtgui/progressconnector.h 2016-10-18 18:30:25 +02:00
Flössie
730c03785d Reapplied clang-tidy filters
- modernize-use-nullptr
- modernize-redundant-void-arg
- readability-simplify-boolean-expr
- misc-redundant-expression
- readability-redundant-control-flow
- readability-avoid-const-params-in-decls
2016-10-18 18:16:05 +02:00
Flössie
0bbc84b2af Merge branch 'master' into clang-tidy 2016-10-18 17:48:50 +02:00
heckflosse
8df2df664f Cppcheck: some fixes 2016-10-17 18:49:15 +02:00
heckflosse
ed42b1239c Merge cppckeck2 branch into master 2016-10-16 22:13:13 +02:00
Hombre
8f2f4e0870 Enhanced ConnectionBlocker class, now used in ToolBar class 2016-10-16 14:19:59 +02:00
Hombre
50165dab20 Merge branch 'master' into softproofing 2016-10-16 01:45:52 +02:00
Flössie
aeaff29ac0 Apply readability-simplify-boolean-expr 2016-10-12 20:01:30 +02:00
heckflosse
e98bd47487 Cppcheck: Fix some warnings 2016-10-12 19:04:06 +02:00
Flössie
19de9d1efa Apply modernize-redundant-void-arg 2016-10-12 18:24:14 +02:00
Flössie
0731975ff0 Apply modernize-use-nullptr
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
Morgan Hardwood
e902091fe9 Fix crash when toggling Before|After view, by Flössie, fixes #3454 2016-10-11 09:46:42 +02:00
heckflosse
b8eb3492c9 colour picker died when crop tool was activated while colour picker was active 2016-10-10 17:10:31 +02:00
heckflosse
0821eea7b6 Cppcheck: Fixed 2 issues introduced with merge of lockable colour picker 2016-10-10 16:28:44 +02:00
Ingo Weyrich
a57ecac9e9 Merge pull request #3452 from Beep6581/cppcheck
merge fixes for a lot of issues reported by Cppcheck
2016-10-09 22:55:31 +02:00
Flössie
d132149a26 Introduce rtengine/noncopyable.hpp 2016-10-08 15:36:44 +02:00
Hombre
e16b2407bd Bugfix: double click to zoom in/out now effective over Pickers
when the Color Picker mode is off.

see issue #1812
2016-10-08 00:44:59 +02:00
Hombre
222b8a7562 Bugfix: Pickers wasn't displayed after a Detail window move
See issue #1812
2016-10-07 14:38:22 +02:00
Hombre
1c8d8c6dce Small code cleanup 2016-10-07 12:48:20 +02:00
Hombre
103091e2c9 Code simplification + bugfix 2016-10-07 02:18:52 +02:00
Hombre
5383a7ab71 Merge branch 'master' into lockable-color-picker 2016-10-07 01:27:33 +02:00
Hombre
773a65b5be Bugfix and using the Navigator's range for displaying values
Thanks a lot to Heckflosse and Floessie for the bugfix
2016-10-07 01:25:45 +02:00
Hombre
f60a4fc4b1 Adding Picker size support and Displayed values support (RGB/HSV/LAB) 2016-10-05 01:13:20 +02:00
heckflosse
18ee91b8e4 Removed rtgui/createicon.cc 2016-10-05 00:04:22 +02:00
heckflosse
e82b60cd03 Cppcheck: Fixed some issues found by Flössie during review of my changes 2016-10-04 23:50:44 +02:00
heckflosse
566d4c9822 Cppcheck: Fixed most issued in rtgui/* 2016-10-04 23:28:19 +02:00
Flössie
162c65e696 Use get_parse_name() in rtgui/dirbrowser.cc (#3444)
This will print the full path and is consistent with the gtk3 branch.
2016-10-04 20:36:28 +02:00
Hombre
23011fbd63 Merge branch 'master' into softproofing 2016-10-04 00:04:57 +02:00
Morgan Hardwood
1c9b84aadb Moved RT.ico from rtgui into rtdata/icons/ 2016-10-03 22:44:13 +02:00
Morgan Hardwood
6d85d35039 Removed non-ASCII characters from code files, closes #3445 2016-10-03 22:05:02 +02:00
heckflosse
3552fd4161 Cppcheck: Fix issues related to explicit constructors 2016-10-03 00:54:02 +02:00
heckflosse
ccd9002c3a Cppcheck: Solve issues related to copy constructor 2016-10-02 23:33:00 +02:00
Hombre
aca00389d9 Solving most if not all bugs left
Still some features to add, but this commit should make this tool fully
usable.
2016-10-02 17:23:09 +02:00
Flössie
ca0afa8d5f Fix incompatibility with glibmm 2.50 (#3440)
Kudos to @Hombre57 for the suggestion.
2016-10-01 12:38:24 +02:00
Hombre
4506247985 Merge branch 'master' into lockable-color-picker 2016-09-30 01:06:19 +02:00
Hombre
f904bc8f84 First patch of the LockableColorPicker tool.
Still Work In Progress, but can be used without too much hassle.
2016-09-30 01:03:57 +02:00
Flössie
8e6cfcb766 Fix use-after-free of ImageArea::mainCropWindow (#3048) 2016-09-29 18:21:37 +02:00
Morgan Hardwood
7d21cbfaa6 Reworked Median (NR) wording, updated RawPedia accordingly. 2016-09-27 23:13:55 +02:00
Hombre
a9fc506ac9 Bugfix: the options file were reseted unexpectedly
The error was that it was reading a wrong value, which thrown an
exception, but the error was diplayed in verbose mode only. Bug fixed,
and now it'll report any error in evry case.
2016-09-03 23:29:26 +02:00
Hombre
a69c631f22 Fix issue #3411 + revert some code to the old one for better readability 2016-09-03 00:49:35 +02:00
Hombre
bdf4665c16 Merge branch 'master' into softproofing 2016-09-02 16:24:14 +02:00
Hombre
c96c7dc8f3 Soft-proofing ang GamutCheck buttons are now disabled if Monitor profile
== NONE of is no suported intent for the selected profile.

The Monitor profile list (in the Editor and in Preferences) shows RGB
profiles only, whereas the output profile list shows all profiles (RGB,
CMYK, ... anything!)

Bugfix: When switching to a new image, the image now use the selected profile and intent.
2016-09-02 16:23:21 +02:00