Alberto Griggio
53a99837e5
histmatching: avoid concavities in the upper part of the matched curve (assumed to be S-shaped)
...
Fixes #4979
2018-11-12 22:23:25 +01:00
Roel Baars
f179eb8333
Add safeguards for setjmp calls when compiling with clang
2018-11-11 14:48:44 +01:00
Roel Baars
83975938ef
Don't use boolean logic to increment value directly
2018-11-11 12:34:12 +01:00
U-PC-BUREAU\jacques
333ac99532
merge with dev
2018-11-11 10:02:38 +01:00
heckflosse
757c1da292
Fix a memory leak, #4966
2018-11-10 21:46:55 +01:00
heckflosse
0f50e738e4
Disabled timing code
2018-11-10 01:12:14 +01:00
U-PC-BUREAU\jacques
fd720007c2
merge with dev
2018-11-09 18:50:41 +01:00
heckflosse
f7109eec21
Improved check for lj92 compressed dng files, #4285
2018-11-09 17:36:13 +01:00
heckflosse
58e26add76
Fallback to 'UniqueCameraModel' tag if model is 'Unknown'
2018-11-09 15:30:29 +01:00
heckflosse
3a51bcd00a
Use linearization table for Blackmagic DNG files, #4285
2018-11-09 14:45:38 +01:00
heckflosse
8d1e1c7237
Merge branch 'dev' into blackmagic-native-support
2018-11-09 14:13:12 +01:00
heckflosse
a1d4acf72f
Artefacts with toncurve 2 / weighted standard with RT-dev-1098, fixes #4948
2018-11-09 13:55:58 +01:00
heckflosse
0f2fc65168
Fix accidently broken 'Blackmagic Pocket Cinema Camera 4K' decoding, #4285
2018-11-09 12:54:37 +01:00
heckflosse
afb3026b70
Decode Magic Lantern CinemaDNG files, #4285
2018-11-09 12:07:14 +01:00
George Hilliard
aa9647954a
Merge remote-tracking branch 'origin/dev' into memory-errors
2018-11-08 15:25:27 -06:00
heckflosse
a29a3b19a9
multithreaded decoding of LJ92 encoded DNG files (for example Blackmagic native DNG files), #4285
2018-11-08 21:03:09 +01:00
heckflosse
2833417133
First version of blackmagic native dng support, #4285
2018-11-08 17:16:32 +01:00
George Hilliard
6cd50adc54
Revert "ImageData: Use terser emplace_back to add unique_ptr to vector"
...
This reverts commit b4813273d21f991789749d30eeb2ac437cdcc698.
2018-11-08 09:57:02 -06:00
heckflosse
2502312242
Small speedup for dehaze, closes #4944
2018-11-08 14:35:03 +01:00
George Hilliard
b4813273d2
ImageData: Use terser emplace_back to add unique_ptr to vector
2018-11-07 12:16:45 -06:00
George Hilliard
a63cd8a87c
Fix mismatched malloc/delete leak, take 2 with cJSON_Delete
...
From the Valgrind report:
```
Mismatched free() / delete / delete []
at 0x4838EAB: operator delete(void*) (vg_replace_malloc.c:576)
by 0xBC5C87: std::default_delete<cJSON>::operator()(cJSON*) const (unique_ptr.h:81)
by 0xBC4ACA: std::unique_ptr<cJSON, std::default_delete<cJSON> >::~unique_ptr() (unique_ptr.h:274)
by 0xBBB755: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
by 0x89743FF: GOMP_parallel_sections (sections.c:158)
by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
by 0x9CE10E: Options::load(bool) (options.cc:2358)
by 0x982CD6: main (main.cc:603)
Address 0xd62d700 is 0 bytes inside a block of size 64 alloc'd
at 0x483777F: malloc (vg_replace_malloc.c:299)
by 0xE97390: cJSON_New_Item (cJSON.c:205)
by 0xE98718: cJSON_ParseWithOpts (cJSON.c:1020)
by 0xE9886F: cJSON_Parse (cJSON.c:1083)
by 0xBBB4D3: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
by 0x89743FF: GOMP_parallel_sections (sections.c:158)
by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
by 0x9CE10E: Options::load(bool) (options.cc:2358)
by 0x982CD6: main (main.cc:603)
```
2018-11-07 12:11:43 -06:00
George Hilliard
7cbf198db8
Revert "Fix mismatched malloc/delete leak"
...
This reverts commit 77eccdf13df8f1190d13d854f5dfd12daca09011.
2018-11-07 11:55:02 -06:00
U-PC-BUREAU\jacques
9cc65909e9
Fixed bug with Blur and Noise for noise
2018-11-07 14:46:55 +01:00
U-PC-BUREAU\jacques
b3e6e75bf7
add detectshape to suppressed code and improve cat02_local
2018-11-07 08:36:21 +01:00
U-PC-BUREAU\jacques
fa3e0a74fc
merge with dev
2018-11-06 19:38:54 +01:00
U-PC-BUREAU\jacques
42fa97506a
Simplify code - reduce artifacts
2018-11-06 17:04:30 +01:00
heckflosse
b8af63bb04
Use vclampf(value, low, high) whereever possible, #4942
2018-11-05 19:50:24 +01:00
heckflosse
8a31f0368c
Use vsqrtf instead of _mm_sqrt_ps
2018-11-05 16:02:32 +01:00
heckflosse
0983817434
SSE: Review usage of vminf, vmaxf functions, #4942
2018-11-05 15:59:41 +01:00
U-PC-BUREAU\jacques
c4d1241354
improvment to tone-mapping local - same as make by Ingo in dev
2018-11-05 15:03:45 +01:00
U-PC-BUREAU\jacques
f47cc199b5
merge with dev
2018-11-05 14:46:23 +01:00
U-PC-BUREAU\jacques
8cac5471e2
Improve shape detection and Excludind spot
2018-11-05 10:54:03 +01:00
heckflosse
fa91103aec
Better fix for #4934
2018-11-05 09:43:45 +01:00
heckflosse
56e45087cf
Segfault when using Tonemapping on completely black data, fixes #4934
2018-11-05 08:17:02 +01:00
U-PC-BUREAU\jacques
aef2ad47e3
merge with dev
2018-11-03 17:24:34 +01:00
heckflosse
fb0d231cb2
use double precision gaussian blur if sigma >= 25, #4928
2018-11-03 14:26:39 +01:00
Hombre
7474598ebc
Fix a crash that can occure when creating the thumbnail (no issue)
2018-11-03 13:59:04 +01:00
Alberto Griggio
0c488eadaf
DR Compression: updated defaults and renamed "Threshold" to "Detail" in the GUI
...
Fixes #4912
2018-11-03 02:36:30 +01:00
heckflosse
240f1eac65
Colortoning lab regions: vectorized last loop, #4914
2018-11-02 23:05:40 +01:00
Ingo Weyrich
d07d06a885
Merge pull request #4919 from Beep6581/labregions-speedup
...
Labregions speedup, closes #4914
2018-11-02 21:42:40 +01:00
heckflosse
64af0e7602
Colortoning lab regions: Disabled timing code and removed double declaration of c_factor, #4914
2018-11-02 21:06:38 +01:00
heckflosse
e199d1ea10
Colortoning lab regions: Move guid fill into main loop, #4914
2018-11-02 19:02:05 +01:00
Alberto Griggio
e611efd6b4
fixed segfault (out of range LUT access) in shadows/highlights
...
Fixes #4922
2018-11-02 12:01:24 +01:00
Alberto Griggio
4186c2b139
L*a*b* grid color toning: fixed scaling bug introduced in 74a467fb4e20aca7b9b9ba40eefa405f0d32e2c4
2018-11-02 13:47:09 +01:00
George Hilliard
ec814dbf05
FramesData: Don't leak allocated frames, and remove unused functions
...
Valgrind report:
```
14,960 (11,544 direct, 3,416 indirect) bytes in 37 blocks are definitely lost in loss record 20,483 of 20,540
at 0x4837DEF: operator new(unsigned long) (vg_replace_malloc.c:334)
by 0xC06963: rtengine::FramesData::FramesData(Glib::ustring const&, std::unique_ptr<rtengine::RawMetaDataLocation, std::default_delete<rtengine::RawMetaDataLocation> >, bool) (imagedata.cc:1121)
by 0xBD774F: rtengine::DFManager::addFileInfo(Glib::ustring const&, bool) (dfmanager.cc:380)
by 0xBD6E90: rtengine::DFManager::init(Glib::ustring) (dfmanager.cc:303)
by 0xC3EC5D: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:93)
by 0x897CABD: gomp_thread_start (team.c:120)
by 0x89B7A9C: start_thread (in /usr/lib/libpthread-2.28.so)
by 0x8ACCB22: clone (in /usr/lib/libc-2.28.so)
```
2018-11-02 03:07:07 -05:00
George Hilliard
5081c85f26
Fix leak of heap-allocated mutexes
2018-11-02 03:07:07 -05:00
George Hilliard
77eccdf13d
Fix mismatched malloc/delete leak
...
From the Valgrind report:
```
Mismatched free() / delete / delete []
at 0x4838EAB: operator delete(void*) (vg_replace_malloc.c:576)
by 0xBC5C87: std::default_delete<cJSON>::operator()(cJSON*) const (unique_ptr.h:81)
by 0xBC4ACA: std::unique_ptr<cJSON, std::default_delete<cJSON> >::~unique_ptr() (unique_ptr.h:274)
by 0xBBB755: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
by 0x89743FF: GOMP_parallel_sections (sections.c:158)
by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
by 0x9CE10E: Options::load(bool) (options.cc:2358)
by 0x982CD6: main (main.cc:603)
Address 0xd62d700 is 0 bytes inside a block of size 64 alloc'd
at 0x483777F: malloc (vg_replace_malloc.c:299)
by 0xE97390: cJSON_New_Item (cJSON.c:205)
by 0xE98718: cJSON_ParseWithOpts (cJSON.c:1020)
by 0xE9886F: cJSON_Parse (cJSON.c:1083)
by 0xBBB4D3: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
by 0x89743FF: GOMP_parallel_sections (sections.c:158)
by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
by 0x9CE10E: Options::load(bool) (options.cc:2358)
by 0x982CD6: main (main.cc:603)
```
2018-11-02 03:06:59 -05:00
heckflosse
47d6ee44f8
Removed accidently committed file
2018-11-01 22:31:12 +01:00
heckflosse
906cf63ecd
Colortoning Lab regions: some vectorized precalculations in first loop, #4914
2018-11-01 22:30:26 +01:00
heckflosse
dd635de72c
Colortoning Lab regions: move some calculations outside last loop, #4914
2018-11-01 20:09:30 +01:00