liz/rawTherapee
liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,205 Commits 1 Branch 0 Tags
Commit Graph

7205 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
heckflosse
e199d1ea10 Colortoning lab regions: Move guid fill into main loop, #4914 2018-11-02 19:02:05 +01:00
Ingo Weyrich
fe4371d915
Merge pull request #4926 from thirtythreeforty/no-startup-ding 
Fix startup ding by initializing variable
 2018-11-02 16:16:46 +01:00
George Hilliard
86c661fdeb Fix startup ding by initializing variable 
Closes #4923.
 2018-11-02 09:47:41 -05:00
Alberto Griggio
e611efd6b4 fixed segfault (out of range LUT access) in shadows/highlights 
Fixes #4922
 2018-11-02 12:01:24 +01:00
Alberto Griggio
4186c2b139 L*a*b* grid color toning: fixed scaling bug introduced in 74a467fb4e20aca7b9b9ba40eefa405f0d32e2c4 2018-11-02 13:47:09 +01:00
George Hilliard
ec814dbf05 FramesData: Don't leak allocated frames, and remove unused functions 
Valgrind report:

```
14,960 (11,544 direct, 3,416 indirect) bytes in 37 blocks are definitely lost in loss record 20,483 of 20,540
   at 0x4837DEF: operator new(unsigned long) (vg_replace_malloc.c:334)
   by 0xC06963: rtengine::FramesData::FramesData(Glib::ustring const&, std::unique_ptr<rtengine::RawMetaDataLocation, std::default_delete<rtengine::RawMetaDataLocation> >, bool) (imagedata.cc:1121)
   by 0xBD774F: rtengine::DFManager::addFileInfo(Glib::ustring const&, bool) (dfmanager.cc:380)
   by 0xBD6E90: rtengine::DFManager::init(Glib::ustring) (dfmanager.cc:303)
   by 0xC3EC5D: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:93)
   by 0x897CABD: gomp_thread_start (team.c:120)
   by 0x89B7A9C: start_thread (in /usr/lib/libpthread-2.28.so)
   by 0x8ACCB22: clone (in /usr/lib/libc-2.28.so)
```
 2018-11-02 03:07:07 -05:00
George Hilliard
5081c85f26 Fix leak of heap-allocated mutexes 2018-11-02 03:07:07 -05:00
George Hilliard
77eccdf13d Fix mismatched malloc/delete leak 
From the Valgrind report:

```
Mismatched free() / delete / delete []
   at 0x4838EAB: operator delete(void*) (vg_replace_malloc.c:576)
   by 0xBC5C87: std::default_delete<cJSON>::operator()(cJSON*) const (unique_ptr.h:81)
   by 0xBC4ACA: std::unique_ptr<cJSON, std::default_delete<cJSON> >::~unique_ptr() (unique_ptr.h:274)
   by 0xBBB755: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
   by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
   by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
   by 0x89743FF: GOMP_parallel_sections (sections.c:158)
   by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
   by 0x9CE10E: Options::load(bool) (options.cc:2358)
   by 0x982CD6: main (main.cc:603)
 Address 0xd62d700 is 0 bytes inside a block of size 64 alloc'd
   at 0x483777F: malloc (vg_replace_malloc.c:299)
   by 0xE97390: cJSON_New_Item (cJSON.c:205)
   by 0xE98718: cJSON_ParseWithOpts (cJSON.c:1020)
   by 0xE9886F: cJSON_Parse (cJSON.c:1083)
   by 0xBBB4D3: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
   by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
   by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
   by 0x89743FF: GOMP_parallel_sections (sections.c:158)
   by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
   by 0x9CE10E: Options::load(bool) (options.cc:2358)
   by 0x982CD6: main (main.cc:603)
```
 2018-11-02 03:06:59 -05:00
Ingo Weyrich
c362c05661
Merge pull request #4902 from thirtythreeforty/fix-batch-gui-notify 
Fix GUI/batch state synchronization
 2018-11-02 01:01:14 +01:00
George Hilliard
424782e8d0 Consolidate updateTab() calls 2018-11-01 16:38:16 -05:00
George Hilliard
cfb61f6fbf Notify GUI when batch starts 
Closes #4906
 2018-11-01 16:34:28 -05:00
heckflosse
47d6ee44f8 Removed accidently committed file 2018-11-01 22:31:12 +01:00
heckflosse
906cf63ecd Colortoning Lab regions: some vectorized precalculations in first loop, #4914 2018-11-01 22:30:26 +01:00
heckflosse
dd635de72c Colortoning Lab regions: move some calculations outside last loop, #4914 2018-11-01 20:09:30 +01:00
heckflosse
41b802bdd3 Colortoning Lab regions: use xlogf and xexpf from sleef.c, #4914 2018-11-01 18:51:17 +01:00
Morgan Hardwood
aeae61f67f Updated Preferences > File Browser > Cache Options 
- UI updated to use grid so that the options nicely align.
- "Clear only cached processing profiles" and "Clear all" buttons are
  hidden when Preferences > Image Processing > Processing profile saving
  location is set to "next to the input file", #4911
 2018-11-01 17:36:20 +01:00
Alberto Griggio
5e30b5ac58 merged 'colortoning-labregions' into 'dev' 2018-11-01 15:18:11 +01:00
Alberto Griggio
a8bbc9cb8b labgrid: code refactoring to avoid duplication for adding reset buttons 2018-11-01 14:25:06 +01:00
Alberto Griggio
e9f0b6ac60 L*a*b* regions: some code cleanups 2018-11-01 13:34:10 +01:00
heckflosse
72787cd990 Set Post-Resize Sharpening Contrast Threshold to 15, fixes #4909 2018-11-01 12:12:01 +01:00
George Hilliard
cc6cbe8347 Distinguish between "desired" and "reported" batch queue state 
This allows the switch to both reflect the state of the queue and
function as an input widget.
 2018-11-01 01:22:46 -05:00
Alberto Griggio
86b282fc68 procparams: call DehazeParams::operator== in ProcParams::operator== 2018-11-01 05:42:45 +01:00
Alberto Griggio
be03d1061a L*a*b* regions: allow for a bit more latitude in corrections 2018-11-01 00:18:59 +01:00
Morgan Hardwood
9a4d770faa Fixing swapped labels 2018-10-31 22:40:45 +01:00
Morgan Hardwood
f897558621 Renamed cache context menu strings #4907 2018-10-31 22:34:28 +01:00
heckflosse
d65767a022 Delete cache file from cache/data when using delete from cache full, #4904 2018-10-31 22:21:43 +01:00
Ingo Weyrich
0bb5d26ed0
Merge pull request #4908 from Beep6581/getridoffeahistogramcache 
Get rid of aehistogram files in RT cache.

Merged to get more tests. Issue and pr stay open for a while
 2018-10-31 21:56:00 +01:00
heckflosse
ebcd737bf8 Don't check for .jpg, .cust, .cust16 files in cache/images folder, third try, #4904 2018-10-31 20:57:21 +01:00
heckflosse
ea5a81b9a1 Don't check for .jpg, .cust, .cust16 files in cache/images folder, second try, #4904 2018-10-31 20:52:58 +01:00
heckflosse
bfe2ce7fe1 Don't check for .jpg, .cust, .cust16 files in cache/images folder, #4904 2018-10-31 20:52:16 +01:00
Alberto Griggio
fb97eeaa5a guided filter: fixed bug due to overlapping input and output arrays 2018-10-31 17:53:47 +01:00
Alberto Griggio
7090730063
Merge pull request #4898 from Beep6581/dehaze 
Dehaze
 2018-10-31 13:26:08 -05:00
heckflosse
473e4bc236 clear cache data folder, #4904 2018-10-31 17:22:03 +01:00
heckflosse
310e734391 Don't create aehistograms folder in RT cache, #4904 2018-10-31 16:21:26 +01:00
heckflosse
f6c864d477 Get rid of aehistogram files in RT cache, fixes #4904 2018-10-31 15:02:53 +01:00
Morgan Hardwood
43876abb81 Reverted changes to 'default' language file #4898 
Commit 14ac4b accidentally wiped all non-ASCII characters from the file
while adding new keys. This commit restores them.
 2018-10-30 23:56:49 +01:00
Alberto Griggio
4eb93c24f8 fixed broken labgrid after previous commit 2018-10-30 22:30:12 +01:00
Morgan Hardwood
cef5d12779 AllowUpscaling=false for old PP3s 
PP3s from before the Allow Upscaling option's introduction to the Resize
tool should defaut to not allow upscaling.
Closes #4643
 2018-10-30 21:18:21 +01:00
Alberto Griggio
74a467fb4e labgrid: work on [0,1] values 2018-10-30 21:12:44 +01:00
heckflosse
1dcf92322d RT crashes with wrong value in profile (curves), fixes #4398 2018-10-30 19:36:37 +01:00
Alberto Griggio
6877360913 DNG: use embedded black and white levels also from files generated by Adobe 
We only override the colour matrix for Adobe DNG Converter (to ensure a consistent look between dng an native raw)
 2018-10-30 14:36:56 +01:00
heckflosse
894fb8d9b3 vng4 demosaic: another small speedup, #4633 2018-10-30 13:45:44 +01:00
George Hilliard
4a765cc91f Unify inconsistent notifyListener() logic 
Previously, this function required a `queueEmptied` bool, which I changed
to `queueRunning`.  But I goofed the logic on this bool; it should
always be "is `processing` nullptr."
 2018-10-29 10:52:06 -05:00
Morgan Hardwood
fb44445f2a Reverted changes to 'default' language file #4893 
Commit 1a3fd9 accidentally wiped all non-ASCII characters from the file
while adding new keys. This commit restores them.
 2018-10-29 11:11:11 +01:00
Alberto Griggio
4d9871110b improved GUI for the "image type" field of dynamic profile rules 2018-10-29 09:36:17 +01:00
Beep6581
5cb42f29e3
Merge pull request #4896 from TooWaBoo/devTWB 
Update TooWaBlue theme (resizing to physical dimensions)
 2018-10-28 23:16:37 +01:00
heckflosse
13abcd0f6c vng4 demosaic: another very small speedup, #4633 2018-10-28 20:37:34 +01:00
Alberto Griggio
50c623802a set LabRegions as the default color toning method 2018-10-28 18:38:55 +01:00
Alberto Griggio
f673a4a881 avoid grabbing focus in the L*a*b* region list 2018-10-28 18:38:40 +01:00
Alberto Griggio
632c1362c8 DNG: honour the BaselineExposure tag 2018-10-28 17:32:15 +01:00