liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,439 Commits 1 Branch 0 Tags
a331f9be9fc3f90a2a0375f09bd46fd097788ed3
Commit Graph

2199 Commits

Author SHA1 Message Date
heckflosse
fa91103aec Better fix for #4934 2018-11-05 09:43:45 +01:00
heckflosse
56e45087cf Segfault when using Tonemapping on completely black data, fixes #4934 2018-11-05 08:17:02 +01:00
heckflosse
fb0d231cb2 use double precision gaussian blur if sigma >= 25, #4928 2018-11-03 14:26:39 +01:00
Hombre
7474598ebc Fix a crash that can occure when creating the thumbnail (no issue) 2018-11-03 13:59:04 +01:00
Alberto Griggio
0c488eadaf DR Compression: updated defaults and renamed "Threshold" to "Detail" in the GUI 
Fixes #4912
 2018-11-03 02:36:30 +01:00
heckflosse
240f1eac65 Colortoning lab regions: vectorized last loop, #4914 2018-11-02 23:05:40 +01:00
Ingo Weyrich
d07d06a885 Merge pull request #4919 from Beep6581/labregions-speedup 
Labregions speedup, closes #4914
 2018-11-02 21:42:40 +01:00
heckflosse
64af0e7602 Colortoning lab regions: Disabled timing code and removed double declaration of c_factor, #4914 2018-11-02 21:06:38 +01:00
heckflosse
e199d1ea10 Colortoning lab regions: Move guid fill into main loop, #4914 2018-11-02 19:02:05 +01:00
Alberto Griggio
e611efd6b4 fixed segfault (out of range LUT access) in shadows/highlights 
Fixes #4922
 2018-11-02 12:01:24 +01:00
Alberto Griggio
4186c2b139 L*a*b* grid color toning: fixed scaling bug introduced in 74a467fb4e 2018-11-02 13:47:09 +01:00
George Hilliard
ec814dbf05 FramesData: Don't leak allocated frames, and remove unused functions 
Valgrind report:

```
14,960 (11,544 direct, 3,416 indirect) bytes in 37 blocks are definitely lost in loss record 20,483 of 20,540
   at 0x4837DEF: operator new(unsigned long) (vg_replace_malloc.c:334)
   by 0xC06963: rtengine::FramesData::FramesData(Glib::ustring const&, std::unique_ptr<rtengine::RawMetaDataLocation, std::default_delete<rtengine::RawMetaDataLocation> >, bool) (imagedata.cc:1121)
   by 0xBD774F: rtengine::DFManager::addFileInfo(Glib::ustring const&, bool) (dfmanager.cc:380)
   by 0xBD6E90: rtengine::DFManager::init(Glib::ustring) (dfmanager.cc:303)
   by 0xC3EC5D: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:93)
   by 0x897CABD: gomp_thread_start (team.c:120)
   by 0x89B7A9C: start_thread (in /usr/lib/libpthread-2.28.so)
   by 0x8ACCB22: clone (in /usr/lib/libc-2.28.so)
```
 2018-11-02 03:07:07 -05:00
George Hilliard
5081c85f26 Fix leak of heap-allocated mutexes 2018-11-02 03:07:07 -05:00
George Hilliard
77eccdf13d Fix mismatched malloc/delete leak 
From the Valgrind report:

```
Mismatched free() / delete / delete []
   at 0x4838EAB: operator delete(void*) (vg_replace_malloc.c:576)
   by 0xBC5C87: std::default_delete<cJSON>::operator()(cJSON*) const (unique_ptr.h:81)
   by 0xBC4ACA: std::unique_ptr<cJSON, std::default_delete<cJSON> >::~unique_ptr() (unique_ptr.h:274)
   by 0xBBB755: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
   by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
   by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
   by 0x89743FF: GOMP_parallel_sections (sections.c:158)
   by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
   by 0x9CE10E: Options::load(bool) (options.cc:2358)
   by 0x982CD6: main (main.cc:603)
 Address 0xd62d700 is 0 bytes inside a block of size 64 alloc'd
   at 0x483777F: malloc (vg_replace_malloc.c:299)
   by 0xE97390: cJSON_New_Item (cJSON.c:205)
   by 0xE98718: cJSON_ParseWithOpts (cJSON.c:1020)
   by 0xE9886F: cJSON_Parse (cJSON.c:1083)
   by 0xBBB4D3: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
   by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
   by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
   by 0x89743FF: GOMP_parallel_sections (sections.c:158)
   by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
   by 0x9CE10E: Options::load(bool) (options.cc:2358)
   by 0x982CD6: main (main.cc:603)
```
 2018-11-02 03:06:59 -05:00
heckflosse
47d6ee44f8 Removed accidently committed file 2018-11-01 22:31:12 +01:00
heckflosse
906cf63ecd Colortoning Lab regions: some vectorized precalculations in first loop, #4914 2018-11-01 22:30:26 +01:00
heckflosse
dd635de72c Colortoning Lab regions: move some calculations outside last loop, #4914 2018-11-01 20:09:30 +01:00
heckflosse
41b802bdd3 Colortoning Lab regions: use xlogf and xexpf from sleef.c, #4914 2018-11-01 18:51:17 +01:00
Alberto Griggio
5e30b5ac58 merged 'colortoning-labregions' into 'dev' 2018-11-01 15:18:11 +01:00
Alberto Griggio
e9f0b6ac60 L*a*b* regions: some code cleanups 2018-11-01 13:34:10 +01:00
heckflosse
72787cd990 Set Post-Resize Sharpening Contrast Threshold to 15, fixes #4909 2018-11-01 12:12:01 +01:00
Alberto Griggio
86b282fc68 procparams: call DehazeParams::operator== in ProcParams::operator== 2018-11-01 05:42:45 +01:00
Alberto Griggio
be03d1061a L*a*b* regions: allow for a bit more latitude in corrections 2018-11-01 00:18:59 +01:00
Ingo Weyrich
0bb5d26ed0 Merge pull request #4908 from Beep6581/getridoffeahistogramcache 
Get rid of aehistogram files in RT cache.

Merged to get more tests. Issue and pr stay open for a while
 2018-10-31 21:56:00 +01:00
Alberto Griggio
fb97eeaa5a guided filter: fixed bug due to overlapping input and output arrays 2018-10-31 17:53:47 +01:00
Alberto Griggio
7090730063 Merge pull request #4898 from Beep6581/dehaze 
Dehaze
 2018-10-31 13:26:08 -05:00
heckflosse
f6c864d477 Get rid of aehistogram files in RT cache, fixes #4904 2018-10-31 15:02:53 +01:00
Morgan Hardwood
cef5d12779 AllowUpscaling=false for old PP3s 
PP3s from before the Allow Upscaling option's introduction to the Resize
tool should defaut to not allow upscaling.
Closes #4643
 2018-10-30 21:18:21 +01:00
Alberto Griggio
74a467fb4e labgrid: work on [0,1] values 2018-10-30 21:12:44 +01:00
heckflosse
1dcf92322d RT crashes with wrong value in profile (curves), fixes #4398 2018-10-30 19:36:37 +01:00
Alberto Griggio
6877360913 DNG: use embedded black and white levels also from files generated by Adobe 
We only override the colour matrix for Adobe DNG Converter (to ensure a consistent look between dng an native raw)
 2018-10-30 14:36:56 +01:00
heckflosse
894fb8d9b3 vng4 demosaic: another small speedup, #4633 2018-10-30 13:45:44 +01:00
heckflosse
13abcd0f6c vng4 demosaic: another very small speedup, #4633 2018-10-28 20:37:34 +01:00
Alberto Griggio
50c623802a set LabRegions as the default color toning method 2018-10-28 18:38:55 +01:00
Alberto Griggio
632c1362c8 DNG: honour the BaselineExposure tag 2018-10-28 17:32:15 +01:00
Alberto Griggio
c63633a76d support for uncompressed 32-bit float DNGs 2018-10-28 10:15:59 +01:00
Alberto Griggio
ce4377d7e5 Initial support for uncompressed 16-bit float DNGs 2018-10-28 09:39:57 +01:00
Ingo Weyrich
b47884bf93 Merge pull request #4897 from Beep6581/vng4-speedup 
Vng4 speedup
 2018-10-27 18:46:25 +02:00
heckflosse
47cfcd51d4 vng4 demosaic: removed StopWatch, fixes #4897 2018-10-27 18:46:02 +02:00
Alberto Griggio
b651cdd40b Merge pull request #4885 from Beep6581/softlight-later-pipeline 
moved softlight later in the pipeline
 2018-10-27 18:03:51 +02:00
Alberto Griggio
7fb90644d3 dehaze: tweak epsilon to avoid artifacts in corner cases 2018-10-27 15:25:38 +02:00
heckflosse
1b291aee9b vng4 demosaic: minor speedup, #4633 2018-10-26 22:20:20 +02:00
heckflosse
3d61eca91f vng4 demosaic: remove unreachable code, #4633 2018-10-26 20:23:27 +02:00
Alberto Griggio
91f9dfe110 labregions: properly scale the guide to [0,1] for the guidedFilter calls 2018-10-26 18:04:41 +02:00
Alberto Griggio
c4ee5e611d guided filter: reuse buffer across boxblur invocations 2018-10-26 18:04:07 +02:00
heckflosse
c44b8ca6a3 vng4 demosaic: move red/blue interpolation inside main loop for better cache usage, #4633 2018-10-26 17:09:28 +02:00
heckflosse
d53e44d45b vng4 demosaic: precalculate weight 2018-10-26 16:51:05 +02:00
heckflosse
b37d88fb22 Always use auto-contrast threshold when using Amaze+VNG4 as demosaicer for motion areas in pixelshift 2018-10-26 14:43:36 +02:00
Alberto Griggio
1a3fd9f157 Added new color toning method "L*a*b* regions" 
Allows to specify various "regions" of the image with masks, and to correct
for hue, saturation and lightness.

Inspired by the existing L*a*b* grid (in turn taken from darktable)
 2018-10-25 16:46:11 +02:00
heckflosse
5134040a5b Merge branch 'dev' into show_flatfield_autoclip_in_gui 2018-10-24 15:40:21 +02:00